Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap fontSize event handler with debounce #400

Closed
bogas04 opened this issue Apr 8, 2018 · 0 comments
Closed

Wrap fontSize event handler with debounce #400

bogas04 opened this issue Apr 8, 2018 · 0 comments
Labels
👶 good-first-pr 🏎 performance

Comments

@bogas04
Copy link
Collaborator

bogas04 commented Apr 8, 2018

We are updating store and saving to localStorage, not really performant to do it as the user slides the slider.
tsingh777 added a commit to tsingh777/SikhiToTheMax-Web that referenced this issue May 22, 2018
@tsingh777
Debounce font size input
74c71b3 
Fixes KhalisFoundation#400
uses https://www.npmjs.com/package/redux-debounced
tsingh777 added a commit to tsingh777/SikhiToTheMax-Web that referenced this issue May 22, 2018
@tsingh777
Debounce font size input
cc54e01 
Fixes KhalisFoundation#400
uses https://www.npmjs.com/package/redux-debounced
@tsingh777 tsingh777 mentioned this issue May 22, 2018
Merged
3 tasks
bogas04 pushed a commit that referenced this issue May 22, 2018
@tsingh777 @bogas04
Fix #400: Debounce font size (#470)
fa25d4a 
* Debounce font size input
Fixes #400
uses https://www.npmjs.com/package/redux-debounced

* update package-lock
@ManjotS ManjotS mentioned this issue Jun 8, 2018
Merged
bogas04 pushed a commit that referenced this issue Jun 9, 2018
@ManjotS @bogas04
9th June 2018 Release
7a5c21f 
# Changelog:

## UI related:
* Error screen doesn’t break UI anymore #365
* Show numeric keyboard for ang mode #489
* Rename Rehatnama source #484
* Typo in footer “Charities”.  #491
* Queries are now encoded to fix “phapha pair bindi “&” breaks search”. #482
* Offline screen is only shown if user is offline and is viewing homepage. #465
* Typo fix in error text ("unusual").
* Debounce font-size action. #400
* Remove English translation from Shabad Meta Box if english isn’t chosen in transliteration/translation #449

## Dev related:
* Upgrade to React 16.4, remove deprecated componentWillReceiveProps API.
* Improve logic of SearchForm to not abuse a bug in getDerivedStateFromProps.
* Preconnect to polyfill.io and banidb for perf gains.
* Moved to husky. #478
* Move served files to public folder. We had a security flaw wherein sttm.co/server/index.js would reveal server code.
@bogas04 bogas04 closed this as completed Jun 15, 2018
bogas04 added a commit that referenced this issue Jul 4, 2018
@bogas04
Major July Release (#514)
a940186 
* Fix #449 (#453)

* Webpack Config change + Bug Fix

* Issue-449: Clean-up

* Acknowledged review comments

* Moved static content to 'public' directory

* Undo last commit

* Acknolwledged review comments

* Move served files to public folder (#457)

* Webpack Config change + Bug Fix

* Issue-449: Clean-up

* Acknowledged review comments

* Moved static content to 'public' directory

* Acknowledged review comments

* Fix #400: Debounce font size (#470)

* Debounce font size input
Fixes #400
uses https://www.npmjs.com/package/redux-debounced

* update package-lock

* Update constants.js

Update spelling of 'unusual' on error page

* Fix #465

* Add location proptypes

* Fix #478 change prepush module to husky (#480)

* 478 change prepush to husky test1

* 478 change prepush to husky test2

* 478 change prepush to husky test3

* Preconnect banidb and polyfill.io

* Fix #482

* added content type header (needed for standards and CDN)

* added charset.. I am unsure if text/html is right or application/javascript or application/json

* revert accidental push

* moved content header to get * on advice of @bogas04

* trying application/json content type as used by api

* Fix #491 #484 #489 (#498)

* Fixes #365 and #496 (#499)

<!-- Before submitting a PR, we would like you to confirm the following: -->

* [ ] <!-- I --> Passed [sanity tests](http://bit.ly/sttm-sanity-tests).
* [ ] <!-- I --> Ran `npm test` & fixed newly introduced lint errors.
* [ ] <!-- I --> Checked console for errors.

<!-- New to markdown? Simply put an 'x' between [ ] to check it. Like [x] this. (No spaces).

* 1.1.4

* Add Remote Sync Feature (#481)

* Initial sync implementation

* Listen to shabadid+highlight from desktop

* Cleanup

* Use realy sync API

* Fix API URL

* Add Sync Link to Header

* Add Vaars to Index

* Show a toast on Sync Connection

* Sundar gutka  (#483)

* Initial commit to fix #477

* Add SG link to header

* Update infrastructure info and deploy script (#494)

* Fix #348 add timeout to fetch requests (#473)

* Add timeout to fetch requests

* 348 add comments to fetch request with timeout

* 348 add ability to pass timeout as prop into Fetch component

* Fix unclickable links after fetching error

* Use GenericError for timeout errors

* Fix API incompatibilities with BaniDB v2

* Fix #490

* Auto close Baanies Sidebar on click, add app promo

* Add link to previously read ang on Home page

* Fix #460

* Fix #471

* Throttle onScroll event for ScrollToTop button

* Disable smooth scrolling for long pages

* Hide Meta/Footer, remove padding, for SG

* Fix #476 (#505)

* Fix #476

* Support unicode and other search types

* Fix a special case

* Analytics for SehajPaathLink

* Fix #248 Add reset to font and display options (#501)

* Add reset to font and display options

* Add reset to font and display options --fix proptype warning

* Add compound action to reset display and font store values

* 248 added redux thunk dependency to handle dispatch of async events

* 248 add redux thunk dependency to handle dispatch of async events

* 248 add string literals to constants file

* Cleanup

* Fix a regression with SearchForm not reacting to URL changes

* Romanized limit to 2, improve green toast

* Fix UI issues with Reset button

* Use route based navigation for SundarGutka

* Support dark mode better

* Use list view

* Fix #511

* Remove autoFocus from Sundar Gutka search

* Fix #506

* Use consistent highlight method between dark and light mode

* Fix #448  Word break for few cases - Sihari, Bihari, etc. (#454)

* #448 - Fix: Word break for few cases - Sihari, Bihari and other Right side matras along with Bindi, Mukta - Many are left

* remove: css - word break - not needed any more

* Fix: combination of matras, half char, bindi tippi

* Fix: larivaar color highlight

* #19: Fix: larivar word break issue o mobile screen, both for Punjabi font and Unicode Font

* #448: Moved code to util

* #448: Moved code to util - assist color

* #448: Larivar moved to separate folder

* Fix: sanity test - Bhai Gurdaas Ji Check:

* #448: remove unwanted code

* #448: Update snapshot tests

* Rename componentWillMount - deprecated/renamed in React v 16.4.0

* removed unsafe method

* fix: variable name

* #19 - Fix: missing style for wordBreakException case, add style instead of class

* Fix: merge conflict

* Use React Component for word, const, cleanup

* Hide Sync from menu

* Fix #515
bogas04 added a commit that referenced this issue Jul 4, 2018
@bogas04
Major July Release
f703de3 
* Fix #449 (#453)

* Webpack Config change + Bug Fix

* Issue-449: Clean-up

* Acknowledged review comments

* Moved static content to 'public' directory

* Undo last commit

* Acknolwledged review comments

* Move served files to public folder (#457)

* Webpack Config change + Bug Fix

* Issue-449: Clean-up

* Acknowledged review comments

* Moved static content to 'public' directory

* Acknowledged review comments

* Fix #400: Debounce font size (#470)

* Debounce font size input
Fixes #400
uses https://www.npmjs.com/package/redux-debounced

* update package-lock

* Update constants.js

Update spelling of 'unusual' on error page

* Fix #465

* Add location proptypes

* Fix #478 change prepush module to husky (#480)

* 478 change prepush to husky test1

* 478 change prepush to husky test2

* 478 change prepush to husky test3

* Preconnect banidb and polyfill.io

* Fix #482

* added content type header (needed for standards and CDN)

* added charset.. I am unsure if text/html is right or application/javascript or application/json

* revert accidental push

* moved content header to get * on advice of @bogas04

* trying application/json content type as used by api

* Fix #491 #484 #489 (#498)

* Fixes #365 and #496 (#499)

<!-- Before submitting a PR, we would like you to confirm the following: -->

* [ ] <!-- I --> Passed [sanity tests](http://bit.ly/sttm-sanity-tests).
* [ ] <!-- I --> Ran `npm test` & fixed newly introduced lint errors.
* [ ] <!-- I --> Checked console for errors.

<!-- New to markdown? Simply put an 'x' between [ ] to check it. Like [x] this. (No spaces).

* 1.1.4

* Add Remote Sync Feature (#481)

* Initial sync implementation

* Listen to shabadid+highlight from desktop

* Cleanup

* Use realy sync API

* Fix API URL

* Add Sync Link to Header

* Add Vaars to Index

* Show a toast on Sync Connection

* Sundar gutka  (#483)

* Initial commit to fix #477

* Add SG link to header

* Update infrastructure info and deploy script (#494)

* Fix #348 add timeout to fetch requests (#473)

* Add timeout to fetch requests

* 348 add comments to fetch request with timeout

* 348 add ability to pass timeout as prop into Fetch component

* Fix unclickable links after fetching error

* Use GenericError for timeout errors

* Fix API incompatibilities with BaniDB v2

* Fix #490

* Auto close Baanies Sidebar on click, add app promo

* Add link to previously read ang on Home page

* Fix #460

* Fix #471

* Throttle onScroll event for ScrollToTop button

* Disable smooth scrolling for long pages

* Hide Meta/Footer, remove padding, for SG

* Fix #476 (#505)

* Fix #476

* Support unicode and other search types

* Fix a special case

* Analytics for SehajPaathLink

* Fix #248 Add reset to font and display options (#501)

* Add reset to font and display options

* Add reset to font and display options --fix proptype warning

* Add compound action to reset display and font store values

* 248 added redux thunk dependency to handle dispatch of async events

* 248 add redux thunk dependency to handle dispatch of async events

* 248 add string literals to constants file

* Cleanup

* Fix a regression with SearchForm not reacting to URL changes

* Romanized limit to 2, improve green toast

* Fix UI issues with Reset button

* Use route based navigation for SundarGutka

* Support dark mode better

* Use list view

* Fix #511

* Remove autoFocus from Sundar Gutka search

* Fix #506

* Use consistent highlight method between dark and light mode

* Fix #448  Word break for few cases - Sihari, Bihari, etc. (#454)

* #448 - Fix: Word break for few cases - Sihari, Bihari and other Right side matras along with Bindi, Mukta - Many are left

* remove: css - word break - not needed any more

* Fix: combination of matras, half char, bindi tippi

* Fix: larivaar color highlight

* #19: Fix: larivar word break issue o mobile screen, both for Punjabi font and Unicode Font

* #448: Moved code to util

* #448: Moved code to util - assist color

* #448: Larivar moved to separate folder

* Fix: sanity test - Bhai Gurdaas Ji Check:

* #448: remove unwanted code

* #448: Update snapshot tests

* Rename componentWillMount - deprecated/renamed in React v 16.4.0

* removed unsafe method

* fix: variable name

* #19 - Fix: missing style for wordBreakException case, add style instead of class

* Fix: merge conflict

* Use React Component for word, const, cleanup

* Hide Sync from menu

* Fix #515

* Fix webpack typo

* 1.1.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👶 good-first-pr 🏎 performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bogas04