Partial cleanup of Q3 to assist merge into QMK.

[tzarc]

This should serve as an example on how to simplify the Keychron modifications and reduce a significant amount of the duplication between boards.

As per the PR Checklist, default/via keymaps are now minimal.
Equivalent keychron_default and keychron_via keymaps now exist which should keep the original functionality, which has been broken out into a higher-level keychron_common and made available for use by all boards with a single implementation.

Please replicate the same changes for all other boards in this PR. If you feel the need to update existing boards in the repository, please raise those as a separate PR.

[adophoxia]

Looking at the new keymap folders, is there a reason there has to be a keychron_[default/via] folder to use #include "keychron_common.h inside their keymap.c files instead of sticking it inside the ones in the [default/via] folders that are already there?

[tzarc]

@adophoxia covered in the description already.

[adophoxia]

Ah ok. Didn't notice that earlier.

[silvinor]

@lokher - As Keychron would not deploy a "default" variant of their own code, having both "keychron_default" and "keychron_via" would just be redundancy on the code. To me, it makes more sense to drop the "keychron_default" variant and the rename "keychron_via" to just "keychron".

This way you would have default, via, and keychron keymap folders - and users would know that the "keychron" one is the build that comes to them from factory.

[lokher]

@lokher - As Keychron would not deploy a "default" variant of their own code, having both "keychron_default" and "keychron_via" would just be redundancy on the code. To me, it makes more sense to drop the "keychron_default" variant and the rename "keychron_via" to just "keychron".

This way you would have default, via, and keychron keymap folders - and users would know that the "keychron" one is the build that comes to them from factory.

that make sense, thank you.