-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature --live-from #198
Conversation
Added support for the --live-from option.
Thank you. |
Sorry for the late review, I was on a trip and forgot about it when I got back. This is a good start. I tested the previous attempt before you decided to redo it, and noticed some issues in regards to the fragment counts shown while downloading. Haven't tested yet, and it doesn't look like it was fixed with the current iteration, but that's something I could work on. I might see if I can push to your branch to help with things, since I would want it to also be able to parse [HH:][MM:]SS durations as well, which the library you are using does not do. |
- Added support for HH:MM:SS strings with a third party library. - Updated the Readme to include detail on usage with the new time format.
Hi, I've added support for HH:MM:SS time strings via another library. It looks like it supports days by putting an hour value >24. Overall, i'm a little unhappy with the Readme wording for the command, it's something I struggle with constantly... Additionally I also have another branch that will add --duration support that I can submit a Pull Request for too. |
Thank you so much for your work! Any chance on a release the following days? Next Friday the 10 Days long Tomorrowland festival 4K stream is starting, and this would come in handy. :-) |
After testing real quick, I realized this doesn't actually work how I expected. It works how you wrote it to work, but now I question the point of setting it to wait a specified amount of time before starting. I would expect it to wait until the stream has gotten to that point in time, not waiting that amount of time from now. i.e. |
Good point, i'll change that as you suggested. It makes much more sense. |
Changed how --live-from works with positive time values. It now calculates the time from the start of the stream.
Updated. --live-from +positive values will calculate from the start of the stream instead. For example, this stream has been live ~68 days so you'd need to use a value like |
Since this pull request has been accepted now, you'll be able to build a version of the application yourself from this repository. |
My first tests were succesful, thx a lot! This behaviour I can't understand, I wanted to start a download of a livestream that's already running, in 2 hours and 40 minutes from now on in the future, here is what it did: ytarchive --vp9 --live-from 2h40m https://www.youtube.com/watch?v=B_dkwPx9J9Y best Is this expected behaviour? |
Sorry, my comment was pretty dumb if I had read the whole conversation. So for my case, maybe addd it as --live-in option? :-) |
When could we expect updated binaries with this new feature? Since it's in the main README I expected it to work in the latest release, but alas it does not. I guess I'll have to compile it myself in the meantime. |
@SimonEast It should be in the |
Oh, I see. On the repository homepage it says that the “latest” is from Aug
2023, so that’s what I downloaded. Didn’t realise that there’s a
pre-release version there that’s actually later than “latest”. Haha. 😉
Thanks for the tip.
|
Added support for the
--live-from
option.This option allows users to specify that they want to start capturing from one of the following:
Usage:
Features:
Fixes #184 and #149