fix(frozen period): exclude empty cash flow categories

KennethTrecy · May 19, 2024 · 44dd0a0 · 44dd0a0
1 parent 5b8041d
commit 44dd0a0
Showing 1 changed file with 15 additions and 2 deletions.
diff --git a/app/Controllers/FrozenPeriodController.php b/app/Controllers/FrozenPeriodController.php
@@ -872,12 +872,12 @@ function ($previous_total, $summary) {
 
                 $opened_liquid_amount = BigRational::zero();
                 $closed_liquid_amount = BigRational::zero();
+                $liquid_cash_flow_category_subtotals = [];
+                $illiquid_cash_flow_category_subtotals = [];
 
                 // Compute for cash flow statement
                 if (isset($categorized_summaries[$currency->id])) {
                     $summaries = $categorized_summaries[$currency->id];
-                    $liquid_cash_flow_category_subtotals = [];
-                    $illiquid_cash_flow_category_subtotals = [];
 
                     foreach ($summaries as $cash_flow_category_id => $account_summaries) {
                         $cash_flow_category = $keyed_categories[$cash_flow_category_id];
@@ -955,6 +955,19 @@ function ($previous_total, $calculation) {
                         }
                     }
 
+                    $liquid_cash_flow_category_subtotals = array_filter(
+                        $liquid_cash_flow_category_subtotals,
+                        function($cash_flow_category_subtotal) {
+                            return $cash_flow_category_subtotal["subtotal"]->getSign() !== 0;
+                        }
+                    );
+                    $illiquid_cash_flow_category_subtotals = array_filter(
+                        $illiquid_cash_flow_category_subtotals,
+                        function($cash_flow_category_subtotal) {
+                            return $cash_flow_category_subtotal["subtotal"]->getSign() !== 0;
+                        }
+                    );
+
                     $opened_liquid_amount = array_reduce(
                         $liquid_cash_flow_category_subtotals,
                         function ($previous_total, $calculation) {