internal(modifier): ensure consistent constraint name

KennethTrecy · Oct 21, 2023 · 2412994 · 2412994
1 parent cc8b44e
commit 2412994
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 5 deletions.
diff --git a/app/Database/Migrations/2023-07-26-022116_CreateModifiersTable.php b/app/Database/Migrations/2023-07-26-022116_CreateModifiersTable.php
@@ -26,7 +26,6 @@ public function up()
             "name" => [
                 "type" => "VARCHAR",
                 "constraint" => "255",
-                "unique" => true,
             ],
             "description" => [
                 "type" => "TEXT",
@@ -49,9 +48,24 @@ public function up()
                 "null" => true,
             ]
         ]);
-        $this->forge->addPrimaryKey("id");
-        $this->forge->addForeignKey("debit_account_id", "accounts", "id", "CASCADE", "CASCADE");
-        $this->forge->addForeignKey("credit_account_id", "accounts", "id", "CASCADE", "CASCADE");
+        $this->forge->addPrimaryKey("id", "pk_modifiers");
+        $this->forge->addUniqueKey("name", "modifiers_name_key");
+        $this->forge->addForeignKey(
+            "debit_account_id",
+            "accounts",
+            "id",
+            "CASCADE",
+            "CASCADE",
+            "modifiers_debit_account_id_foreign"
+        );
+        $this->forge->addForeignKey(
+            "credit_account_id",
+            "accounts",
+            "id",
+            "CASCADE",
+            "CASCADE",
+            "modifiers_credit_account_id_foreign"
+        );
         $this->forge->createTable("modifiers");
     }
 

diff --git a/app/Database/Migrations/2023-09-22-153035_RenewModifierUniqueness.php b/app/Database/Migrations/2023-09-22-153035_RenewModifierUniqueness.php
@@ -15,7 +15,14 @@ public function up()
         if ($database->DBDriver === "SQLite3") return;
 
         $this->forge->dropKey("modifiers", "modifiers_name_key", false);
-        $this->forge->addUniqueKey([ "debit_account_id", "credit_account_id", "name" ]);
+        $this->forge->addUniqueKey(
+            [
+                "debit_account_id",
+                "credit_account_id",
+                "name"
+            ],
+            "modifiers_debit_account_id_credit_account_id_name"
+        );
         $this->forge->processIndexes("modifiers");
     }