Safely check ucode handlers for out of range or missing opcode #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitely a situation we want to log it out when the code is not within the map |
What log level should we use, |
I'm thinking WARN. |
louist103
reviewed
Apr 7, 2024
louist103
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The execution of the ucode handlers would crash if a bad ucode index was loaded, or the opcode has no handler.
This first adds a bounds check for the index being within the array size of ucode_handlers, and if it isn't, trip a debug
assertas the call toG_LOAD_UCODEwas incorrect. Alternatively, we could move theassertto be insidegfx_set_ucode_handler.The second is to add a
containscheck for the opcode on the specific ucode handler before accessing the map. If the opcode is not recognized, it silently skips over it. I'm not sure if we would also want a debugasserthere, or maybe logging, thoughts?