-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to MEMListPolicies #1082
Merged
KelvinTegelaar
merged 2 commits into
KelvinTegelaar:dev
from
Ren-Roros-Digital:listconfig
Oct 4, 2024
Merged
Improvements to MEMListPolicies #1082
KelvinTegelaar
merged 2 commits into
KelvinTegelaar:dev
from
Ren-Roros-Digital:listconfig
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses +=, cant accept. |
b411584
to
5d67605
Compare
@KelvinTegelaar i can't think of a different way to do this, i originally didn't use += until CoPilot made everything work with the += method |
5d67605
to
92233b8
Compare
@OfficialEsco I've rewritten it to be more performant and not use +=. I would have added the change myself but it appears I cannot commit to your PR.
|
Co-Authored-By: John Duprey <15741649+JohnDuprey@users.noreply.github.com>
143f691
to
3d9b1e3
Compare
Ahh you beauty, works like a charm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.