Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally Send+Sync Context #688

Merged
merged 7 commits into from
Nov 1, 2021

Conversation

moschroe
Copy link
Contributor

As requested, new PR. I added type aliases which make the generated docs way more clear and it helps distinguish the use cases. For any active users of tera, nothing should change at all. The new functionality of having non-static and non-Send & non-Sync Context-local functions is opt-in by deliberately using Context::new_threadlocal().

Copy link
Owner

@Keats Keats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test to prove the normal context is Send+Sync so it doesn't happen anymore? Looks good otherwise!

@moschroe moschroe requested a review from Keats October 31, 2021 12:28
@Keats Keats merged commit 7e5daf5 into Keats:master Nov 1, 2021
@Keats
Copy link
Owner

Keats commented Nov 1, 2021

Thanks, i'll yank 1.13 and release 1.14

Keats added a commit that referenced this pull request Nov 2, 2021
Keats added a commit that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants