-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made the Error struct Send + Sync #458
Conversation
Thanks, can you add a test like https://stackoverflow.com/questions/41599921/how-to-define-a-struct-that-is-sendsync-and-is-holding-a-iowrite-member?rq=1 to ensure it's correct? |
Now the problem is that the CI fails because a command containing |
For the Windows failure I'm confused, it passes on https://github.com/Keats/tera/pull/353/checks?check_run_id=267363501 |
Probably Beta stuff. I'm not even sure where to check for changes in GitHub Actions, but probably something has been changed in the last ~8 days. PR to fix that too: #459 |
Based on code reviews, this is better. I've edited this on github directly, so please just work.
Thanks! |
In order to be able to construct
anyhow::Error
s fromtera::Error
s, we must make this crate errorsSend + Sync
.To do so it's only necessary to change 3 lines of code, but I'm not sure whether this is going to be a breaking change or not.
IMO this is a small but great addition that contributes to the usability of this crate.
Edit:
Fixes #442