Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the Error struct Send + Sync #458

Merged
merged 4 commits into from
Oct 28, 2019
Merged

Made the Error struct Send + Sync #458

merged 4 commits into from
Oct 28, 2019

Conversation

AxelMontini
Copy link
Contributor

@AxelMontini AxelMontini commented Oct 28, 2019

In order to be able to construct anyhow::Errors from tera::Errors, we must make this crate errors Send + Sync.

To do so it's only necessary to change 3 lines of code, but I'm not sure whether this is going to be a breaking change or not.

IMO this is a small but great addition that contributes to the usability of this crate.

Edit:
Fixes #442

@Keats
Copy link
Owner

Keats commented Oct 28, 2019

@AxelMontini
Copy link
Contributor Author

Now the problem is that the CI fails because a command containing && is being run on windows. Gonna create a PR for that too.

@Keats
Copy link
Owner

Keats commented Oct 28, 2019

For the Windows failure I'm confused, it passes on https://github.com/Keats/tera/pull/353/checks?check_run_id=267363501

@AxelMontini
Copy link
Contributor Author

For the Windows failure I'm confused, it passes on https://github.com/Keats/tera/pull/353/checks?check_run_id=267363501

Probably Beta stuff. I'm not even sure where to check for changes in GitHub Actions, but probably something has been changed in the last ~8 days.

PR to fix that too: #459

Based on code reviews, this is better.

I've edited this on github directly, so please just work.
@Keats Keats merged commit 3839dfc into Keats:v1 Oct 28, 2019
@Keats
Copy link
Owner

Keats commented Oct 28, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants