Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1533 #3423

Merged
merged 1 commit into from
Feb 23, 2024
Merged

fixes #1533 #3423

merged 1 commit into from
Feb 23, 2024

Conversation

JonasKlamroth
Copy link
Contributor

Related Issue

This pull request addresses #1533 .

Intended Change

This replaces the fix seperator "," with a static final String which may be set arbitrarily. This resolved the described problems in the description of the issue.

Type of pull request

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • Refactoring (behaviour should not change or only minimally change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • [ x ] There are changes to the (Java) code
  • There are changes to the taclet rule base
  • There are changes to the deployment/CI infrastructure (gradle, github, ...)
  • Other:

Ensuring quality

  • [ x ] I made sure that introduced/changed code is well documented (javadoc and inline comments).
  • [ x ] I made sure that new/changed end-user features are well documented (https://github.com/KeYProject/key-docs).
  • I added new test case(s) for new functionality.
  • [ x ] I have tested the feature as follows: Saved CSV-statistics and loaded it. Saved proof files and loaded them.
  • [ x ] I have checked that runtime performance has not deteriorated.

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.91%. Comparing base (1fb0c10) to head (dd1a99f).
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3423      +/-   ##
============================================
+ Coverage     37.77%   37.91%   +0.14%     
- Complexity    17031    17069      +38     
============================================
  Files          2076     2076              
  Lines        126950   127019      +69     
  Branches      21381    21388       +7     
============================================
+ Hits          47952    48164     +212     
+ Misses        73092    72949     -143     
  Partials       5906     5906              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wadoon
Copy link
Member

wadoon commented Feb 23, 2024

force pushed for reformatting

@wadoon
Copy link
Member

wadoon commented Feb 23, 2024

On the other side, we might want to migrate from csv to something more robust like Json. The ci-tool offers already such an export for further script-based analysis.

@wadoon wadoon added this pull request to the merge queue Feb 23, 2024
Merged via the queue into KeYProject:main with commit ed673b0 Feb 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants