Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a NullPointerException when the configuration files for the "Recent Files" feature is not yet created #3225

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

unp1
Copy link
Member

@unp1 unp1 commented Jul 25, 2023

We must ensure to create the "recentFiles" configuration file before passing the File object to an InputStream.

…cent Files" feature is not yet created

We must ensure to create the "recentFiles" configuration file before passing the File object to an InputStream.
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #3225 (c628a78) into main (0ac6d7f) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3225      +/-   ##
============================================
- Coverage     37.74%   37.72%   -0.02%     
+ Complexity    16858    16851       -7     
============================================
  Files          2054     2054              
  Lines        126475   126475              
  Branches      21255    21255              
============================================
- Hits          47736    47711      -25     
- Misses        72896    72920      +24     
- Partials       5843     5844       +1     

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Thank you for your contribution.

The test artifacts are available on Artiweb.
The newest artifact is here.

@unp1
Copy link
Member Author

unp1 commented Jul 25, 2023

The reduced test coverage is an unrelated file occurs because the exception is no longer thrown and hence the corresponding catch block in DiskFileRepo is no longer reached. That is expected behavior and should be ignored.

@wadoon wadoon self-requested a review July 25, 2023 21:18
@wadoon wadoon added this pull request to the merge queue Jul 25, 2023
@wadoon wadoon removed this pull request from the merge queue due to a manual request Jul 25, 2023
@wadoon wadoon changed the base branch from main to KeY-2.8.0 July 25, 2023 21:19
@wadoon wadoon changed the base branch from KeY-2.8.0 to KeY-2.12.0 July 25, 2023 21:19
@wadoon
Copy link
Member

wadoon commented Jul 25, 2023

Switch to the release branch. We merge the release branch later into main.

@wadoon wadoon merged commit 0ccf763 into KeY-2.12.0 Jul 25, 2023
15 of 16 checks passed
@wadoon wadoon deleted the fixNPERecentFiles branch July 25, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants