Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various UI bugs #3216

Merged
merged 44 commits into from
Jul 30, 2023
Merged

Fix various UI bugs #3216

merged 44 commits into from
Jul 30, 2023

Conversation

FliegendeWurst
Copy link
Member

@FliegendeWurst FliegendeWurst commented Jul 22, 2023

I recommend reviewing this PR commit-by-commit. Most of the bugs were found using the new UI testing facility (3d73e59).

Fixes #3228, #3227, #3215, #1648, #1652 (comment), #1526, #1117 and task 1+4 of #3214

@FliegendeWurst FliegendeWurst added GUI 🛠 Maintenance Code quality and related things w/o functional changes labels Jul 22, 2023
@FliegendeWurst FliegendeWurst added this to the v2.12.0 milestone Jul 22, 2023
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #3216 (cbd6e0c) into KeY-2.12.0 (c628a78) will increase coverage by 0.03%.
Report is 12 commits behind head on KeY-2.12.0.
The diff coverage is 76.59%.

@@               Coverage Diff                @@
##             KeY-2.12.0    #3216      +/-   ##
================================================
+ Coverage         37.72%   37.76%   +0.03%     
- Complexity        16851    16872      +21     
================================================
  Files              2054     2053       -1     
  Lines            126475   126494      +19     
  Branches          21255    21258       +3     
================================================
+ Hits              47711    47766      +55     
+ Misses            72920    72884      -36     
  Partials           5844     5844              
Files Changed Coverage Δ
.../ilkd/key/prover/impl/DefaultTaskFinishedInfo.java 26.66% <0.00%> (-1.91%) ⬇️
...n/java/de/uka/ilkd/key/settings/ProofSettings.java 73.07% <22.22%> (-2.18%) ⬇️
...ka/ilkd/key/proof/reference/ReferenceSearcher.java 83.56% <90.00%> (+4.99%) ⬆️
...ore/src/main/java/de/uka/ilkd/key/proof/Proof.java 77.67% <100.00%> (+0.47%) ⬆️
...de/uka/ilkd/key/proof/init/KeYUserProblemFile.java 74.35% <100.00%> (+0.33%) ⬆️
...ore/src/main/java/de/uka/ilkd/key/rule/Taclet.java 77.96% <100.00%> (+0.41%) ⬆️
...in/java/de/uka/ilkd/key/settings/ViewSettings.java 38.34% <100.00%> (+1.42%) ⬆️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mattulbrich
Copy link
Member

#3214 could be of interest here too.

@github-actions
Copy link

github-actions bot commented Jul 22, 2023

Thank you for your contribution.

The test artifacts are available on Artiweb.
The newest artifact is here.

@WolframPfeifer WolframPfeifer changed the base branch from main to KeY-2.12.0 July 24, 2023 09:09
@FliegendeWurst FliegendeWurst added the Infrastructure Changes to the Github configurations, repository or other non-source stuff label Jul 27, 2023
@wadoon wadoon merged commit d315c33 into KeYProject:KeY-2.12.0 Jul 30, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Infrastructure Changes to the Github configurations, repository or other non-source stuff 🛠 Maintenance Code quality and related things w/o functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading a PO from the project manager makes KeY freeze
4 participants