-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce clutter in toolbar #3198
Reduce clutter in toolbar #3198
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3198 +/- ##
=========================================
Coverage 37.59% 37.59%
Complexity 16684 16684
=========================================
Files 2043 2043
Lines 125713 125713
Branches 21106 21106
=========================================
Hits 47256 47256
Misses 72693 72693
Partials 5764 5764
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Yes the layout toolbar can be moved to a menu. |
@WolframPfeifer I believe the bug that extension panels sometimes fail to show up is fixed with the latest commit. |
834d200
to
94b89b3
Compare
94b89b3
to
7996258
Compare
key.ui/src/main/java/de/uka/ilkd/key/gui/extension/impl/KeYGuiExtensionFacade.java
Show resolved
Hide resolved
I tested it by switching to an older branch without proof slicing and then back to this one, and the slicing panel appeared as expected. Thanks! |
This reverts commit 07addf2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few final requests (see my suggestions). I would like to have the status line messages harmonized to Layout saved to ...
and Layout loaded from ...
.
Otherwise, I think the PR is fine and really increases usability of KeY.
key.ui/src/main/java/de/uka/ilkd/key/gui/extension/impl/KeYGuiExtensionFacade.java
Outdated
Show resolved
Hide resolved
key.ui/src/main/java/de/uka/ilkd/key/gui/docking/DockingLayout.java
Outdated
Show resolved
Hide resolved
key.ui/src/main/java/de/uka/ilkd/key/gui/docking/DockingLayout.java
Outdated
Show resolved
Hide resolved
I have integrated all of your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
View menu:
This reduces clutter in the main toolbar by:
As a bonus, the bug that extension panels sometimes fail to show up should also be fixed.