Skip to content

Commit

Permalink
ata: libata-scsi: improve ata_scsiop_maint_in()
Browse files Browse the repository at this point in the history
Allow translation of REPORT_SUPPORTED_OPERATION_CODES commands using
the command format 0x3, that is, checking support for commands that are
identified using an opcode and a service action.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
  • Loading branch information
Damien Le Moal committed Jan 4, 2023
1 parent 7574a83 commit 002c487
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/ata/libata-scsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -3266,11 +3266,12 @@ static unsigned int ata_scsiop_maint_in(struct ata_scsi_args *args, u8 *rbuf)
u8 supported = 0;
unsigned int err = 0;

if (cdb[2] != 1) {
if (cdb[2] != 1 && cdb[2] != 3) {
ata_dev_warn(dev, "invalid command format %d\n", cdb[2]);
err = 2;
goto out;
}

switch (cdb[3]) {
case INQUIRY:
case MODE_SENSE:
Expand Down

0 comments on commit 002c487

Please sign in to comment.