Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add character pictures #391

Merged
merged 2 commits into from
May 26, 2023
Merged

Add character pictures #391

merged 2 commits into from
May 26, 2023

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented May 26, 2023

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

Code Generators

The use of GitHub Copilot or ChatGPT is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot or ChatGPT.

Changes Made

List any changes made and/or other relevant issues.

  • Add missing character pictures
  • Fix toString for character

https://github.com/KatsuteDev/Mal4J/actions/runs/5086057192

Release Notes

This is an undocumented feature, you must use MyAnimeList.enableExperimentalFeature(ExperimentalFeature.CHARACTERS) to enable it.

@Katsute Katsute self-assigned this May 26, 2023
@Katsute

This comment has been minimized.

@ghost

This comment has been minimized.

@Katsute

This comment has been minimized.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @Katsute

@Katsute Katsute merged commit 0426283 into main May 26, 2023
@Katsute Katsute deleted the cp@3d5ce75 branch May 26, 2023 01:09
@ghost ghost locked and limited conversation to collaborators May 26, 2023
@Katsute
Copy link
Member Author

Katsute commented May 26, 2023

mal character/61371?fields=num_favorites,v,va,voice_actor,voice_actors

@ghost
Copy link

ghost commented May 26, 2023

https://api.myanimelist.net/v2/character/61371?fields=num_favorites,v,va,voice_actor,voice_actors

{
    "message": "",
    "error": "not_found"
}

@Katsute
Copy link
Member Author

Katsute commented May 26, 2023

mal people/34785?fields=chara,character,characters,num_favorites

@ghost
Copy link

ghost commented May 26, 2023

https://api.myanimelist.net/v2/people/34785?fields=chara,character,characters,num_favorites

{
    "id": 34785,
    "num_favorites": 53193
}

@Katsute
Copy link
Member Author

Katsute commented May 26, 2023

mal characters/61371?fields=num_favorites,v,va,voice_actor,voice_actors

@ghost
Copy link

ghost commented May 26, 2023

https://api.myanimelist.net/v2/characters/61371?fields=num_favorites,v,va,voice_actor,voice_actors

{
    "id": 61371,
    "num_favorites": 16640
}

@Katsute
Copy link
Member Author

Katsute commented May 27, 2023

mal people/34785?fields=id,first_name,last_name,alternative_names,num_favorites,main_picture,birthday,family_name,website,more,pictures

@ghost
Copy link

ghost commented May 27, 2023

https://api.myanimelist.net/v2/people/34785?fields=id,first_name,last_name,alternative_names,num_favorites,main_picture,birthday,family_name,website,more,pictures

{
    "id": 34785,
    "first_name": "Rie",
    "last_name": "Takahashi",
    "alternative_names": [
        "Rieri",
        "Rii-chan"
    ],
    "num_favorites": 53226,
    "main_picture": {
        "medium": "https://cdn.myanimelist.net/images/voiceactors/2/62615.jpg"
    },
    "birthday": "1994-02-27",
    "more": "Birth place: Saitama Prefecture, Japan<br />\r\n<br />\r\nShe is apart of the seiyuu unit Earphones, which was created during the production of Sore ga Seiyuu and the members are comprised of herself, Marika Kouno and Yuki Nagaku.<br />\r\n <br />\r\nProfile: [url=https://www.81produce.co.jp/actor_search/index.php/item?id=236]81Produce[/url]<br />\r\nTwitter: @[url=http://twitter.com/taka8rie]taka8rie[/url], @[url=https://twitter.com/taka8rie_staff/]taka8rie_staff[/url]<br />\r\nInstagram: @[url=https://www.instagram.com/riery_syame/]riery_syame[/url]<br />\r\nYoutube: [url=https://www.youtube.com/c/taka8rie]高橋李依 / Rie Takahashi Official YouTube Channel[/url]<br />\r\nBlog: [url=https://ameblo.jp/taka8rie/]Ameba[/url]"
}

@Katsute
Copy link
Member Author

Katsute commented May 27, 2023

mal people/10765?fields=id,first_name,last_name,alternative_names,num_favorites,main_picture,birthday,family_name,website,more,pictures

@ghost
Copy link

ghost commented May 27, 2023

https://api.myanimelist.net/v2/people/10765?fields=id,first_name,last_name,alternative_names,num_favorites,main_picture,birthday,family_name,website,more,pictures

{
    "id": 10765,
    "first_name": "Ai",
    "last_name": "Kayano",
    "alternative_names": [],
    "num_favorites": 25442,
    "main_picture": {
        "medium": "https://cdn.myanimelist.net/images/voiceactors/3/60503.jpg"
    },
    "birthday": "1987-09-13",
    "more": "Blood type: O<br />\r\nBirth place: Tokyo, Japan<br />\r\nNickname: Kayanon (かやのん)<br />\r\n<br />\r\nAi Kayano became interested in voice acting while watching foreign films, which are dubbed into Japanese in Japan. While she learned about the seiyuu profession in high school, she was first interested in becoming a beautician. After completing beauty vocational school, Kayano enrolled in the Pro-Fit Voice Actor&#039;s School and graduated in 2010, debuting that April as a professional seiyuu.<br />\r\n<br />\r\nKayano took on a number of minor roles before landing her first regular role as Itsuwa in the [i]Toaru Majutsu no Index[/i] series. In 2011, she debuted in her first lead role in [i]Ano Hi Mita Hana no Namae wo Bokutachi wa Mada Shiranai.[/i] as Meiko Honma. Kayano&#039;s performance in the series resulted in her being named a Newcomer of the Year in the 6th Annual Seiyuu Awards.<br />\r\n<br />\r\nKayano left the Pro-Fit talent agency in September 2014 and joined Office Osawa in January 2015.<br />\r\n<br />\r\nAs a fan of sake, Kayano hosts a web program titled [url=https://www.youtube.com/channel/UC0D6qi-Gr5RW7hqOvTEKmAw][i]Kayanomi[/i][/url] in which she samples various kinds of sake.<br />\r\n<br />\r\n[i]Personal[/i] Twitter: @[url=https://twitter.com/kayanoai_0913]kayanoai_0913[/url]<br />\r\n[i]Kayanomi[/i] Twitter: @[url=https://twitter.com/_kayanomi]_kayanomi[/url]<br />\r\nProfile: [url=http://osawa-inc.co.jp/women/kayanoai/]osawa-inc.co.jp/women/k...[/url]"
}

@Katsute
Copy link
Member Author

Katsute commented May 27, 2023

mal people/160?fields=id,first_name,last_name,alternative_names,num_favorites,main_picture,birthday,family_name,website,more,pictures

@ghost
Copy link

ghost commented May 27, 2023

https://api.myanimelist.net/v2/people/160?fields=id,first_name,last_name,alternative_names,num_favorites,main_picture,birthday,family_name,website,more,pictures

{
    "id": 160,
    "first_name": "Takehito",
    "last_name": "Koyasu",
    "alternative_names": [],
    "num_favorites": 33157,
    "main_picture": {
        "medium": "https://cdn.myanimelist.net/images/voiceactors/1/63375.jpg"
    },
    "birthday": "1967-05-05",
    "more": "Blood type: A<br />\r\nHeight: 175 cm<br />\r\nWeight: 60 kg<br />\r\n<br />\r\nFavorites:<br />\r\nBeverages: milk, brandy<br />\r\nColors: black, white, blue<br />\r\nCountry: Egypt<br />\r\nAnimal: Giraffe<br />\r\nBrands of clothing: Fila, Donna Karan, Van, Ships<br />\r\nDate spot: the sea<br />\r\nMusic group: L&#039;arc~en~Ciel<br />\r\nTV show: &quot;trendy&quot; dramas<br />\r\nFlower: yellow rose<br />\r\nFoods: ebi, tofu, men&#039;s pocky<br />\r\nIdol: Mita Hiroko<br />\r\nSeason: autumn<br />\r\n<br />\r\nHobbies: snowboarding, video games, writing<br />\r\nSkills &amp; Abilities: baseball, designing signatures, E Rank Driver, jump rope, photography<br />\r\n<br />\r\nAccording to the Anime News Network, as of December 2008, Koyasu is the most prolific seiyuu in Japan with voice acting roles in 365 anime series. He is also part of the seiyuu quartet Weiss consisting of Weiss Kreuz voice castmates Shinichiro Miki, Tomokazu Seki, and Yuuki Hiro. He used to work for Production Baobab but is now the head of T&#039;s Factory, a seiyuu company he founded in 1998.<br />\r\n<br />\r\nKoyasu is known for his deep, smooth voice, which often lands him in roles that are either villains or lonely bishounen. Recently, though (as in the cases of Mitsurugi Hanagata from [i]Saber Marionette J[/i], Ryo Kuroyanagi from [i]Yakitate!! Japan[/i], Bobobo-Bo-Bobobo, and Kei Itoshiki from [i]Zoku Sayonara Zetsubo Sensei[/i]) he has been voicing more and more lively/humorous characters. According to Hisaya Nakajo, the mangaka of the series Hana-Kimi, the character of Masao Himejima was designed with Koyasu&#039;s voice in mind; the seiyuu ended up voicing this character in the series&#039; drama CDs.<br />\r\n<br />\r\nKoyasu is also the creator of the Wei&szlig; series, and has authored the manga Wei&szlig; Side B. In creating Wei&szlig; Kreuz, Koyasu was inspired by an old Japanese series called Sure Death.<br />\r\n<br />\r\nKoyasu often voices under the pseudonym Hayato Jumonji, especially in H anime.<br />\r\n<br />\r\nHe also narrates promotional videos and pre-flight safety videos for StarFlyer."
}

@Katsute Katsute added this to the 3.3.0 milestone May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant