Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add people support #389

Merged
merged 2 commits into from
May 24, 2023
Merged

Add people support #389

merged 2 commits into from
May 24, 2023

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented May 24, 2023 •
edited
Loading

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

Code Generators

The use of GitHub Copilot or ChatGPT is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot or ChatGPT.

Changes Made

List any changes made and/or other relevant issues.

  • Added person endpoint

https://github.com/KatsuteDev/Mal4J/actions/runs/5072826144

Release Notes

This is an undocumented feature, you must use MyAnimeList.enableExperimentalFeature(ExperimentalFeature.PEOPLE) to enable it.

Retrieve people using MyAnimeList.getPerson(id).

Person information currently includes:

  • Name
  • Birthday
  • Picture

@Katsute Katsute added this to the 3.2.0 milestone May 24, 2023
@Katsute Katsute self-assigned this May 24, 2023
@Katsute Katsute linked an issue May 24, 2023 that may be closed by this pull request
Add people support #387
Closed
@Katsute Katsute marked this pull request as ready for review May 24, 2023 18:20
@Katsute Katsute changed the title Add person support Add people support May 24, 2023
@Katsute

This comment has been minimized.

Sign in to view
@ghost

This comment has been minimized.

Sign in to view
@Katsute

This comment has been minimized.

Sign in to view
ghost
ghost approved these changes May 24, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @Katsute

@Katsute Katsute merged commit e236be4 into main May 24, 2023
@Katsute Katsute deleted the people@61dfa40 branch May 24, 2023 19:58
@ghost ghost locked and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees

@Katsute Katsute

Labels
experimental feature request MyAnimeList API
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

Add people support
1 participant
@Katsute