Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add character support #381

Merged
merged 7 commits into from
May 22, 2023
Merged

Add character support #381

merged 7 commits into from
May 22, 2023

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented May 21, 2023

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

Code Generators

The use of GitHub Copilot or ChatGPT is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot or ChatGPT.

Changes Made

List any changes made and/or other relevant issues.

  • Add character

https://github.com/KatsuteDev/Mal4J/actions/runs/5040940621

Release Notes

This is an undocumented feature, you must use MyAnimeList.enableExperimentalFeature(ExperimentalFeature.CHARACTERS) to enable it.

Retrieve characters using MyAnimeList.getCharacter(id).

Character information currently includes:

  • Name
  • Alternative names
  • Picture
  • Biography
  • Animeography

@Katsute Katsute marked this pull request as ready for review May 22, 2023 01:48
@Katsute

This comment has been minimized.

@ghost

This comment has been minimized.

@Katsute

This comment has been minimized.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @Katsute

@Katsute Katsute merged commit 538687d into main May 22, 2023
@Katsute Katsute deleted the character@9989d2d branch May 22, 2023 02:09
@ghost ghost locked and limited conversation to collaborators May 22, 2023
@Katsute Katsute added this to the 3.1.0 milestone May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant