New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON parsing optimizations #364

Merged

Katsute merged 6 commits into main from json-optimization@b6517ca

Feb 14, 2023

Member

Katsute commented Feb 12, 2023 •

edited by ghost

Loading

Prerequisites

Issues must meet the following criteria:

No similar pull request exists.
Code follows the general code style of this project.
No sensitive information is exposed.
Relevant comments have been added.

GitHub Copilot Disclaimer

The use of GitHub Copilot is strictly prohibited on this repository.

This pull does not use GitHub Copilot.

Changes Made

List any changes made and/or other relevant issues.

Use json optimizations from https://github.com/KatsuteDev/OneMTA/blob/f6c82a376dcd98b1a77ed9cd3e6bf04ee098ffd5/src/main/java/dev/katsute/onemta/Json.java
Replaces regex parsing with character-by-character parsing

Release Notes

This library is now 70% faster after this change.


          Empty commit

dd07388

Katsute added the optimization label

Katsute self-assigned this


          port over json from OneMTA

ed962e8

https://github.com/KatsuteDev/OneMTA/blob/f6c82a376dcd98b1a77ed9cd3e6bf04ee098ffd5/src/main/java/dev/katsute/onemta/Json.java

github-advanced-security bot found potential problems

View reviewed changes

src/main/java/dev/katsute/mal4j/Json.java

+                      for(int i = start + 1; i < end; i++){
+                          final char ch = json.charAt(i);
+                          switch(E){

Check warning

Code scanning / CodeQL

Missing enum case in switch

Switch statement does not have a case for [END_OF_KEY](1). Switch statement does not have a case for [KEY](2). Switch statement does not have a case for [START_OF_KEY](3).

src/main/java/dev/katsute/mal4j/Json.java

-                              throw new JsonSyntaxException("Unexpected array value syntax: '" + ln + '\'', json);
+                                  continue;
+                              case LITERAL: // expecting literal value
+                                  switch(T){

Check warning

Code scanning / CodeQL

Missing enum case in switch

Switch statement does not have a case for [UNKNOWN](1).

src/main/java/dev/katsute/mal4j/Json.java

-                              throw new JsonSyntaxException("Unexpected object value syntax: '" + ln + '\'', json);
+                                  continue;
+                              case LITERAL: // expecting literal value
+                                  switch(T){

Check warning

Code scanning / CodeQL

Missing enum case in switch

Switch statement does not have a case for [UNKNOWN](1).

src/main/java/dev/katsute/mal4j/Json.java

+                                      case ',': // next in object
+                                      case '}': // end of object
+                                          E = START_OF_KEY; // prepare for next
+                                          switch(T){ // push value

Check warning

Code scanning / CodeQL

Missing enum case in switch

Switch statement does not have a case for [UNKNOWN](1).

src/main/java/dev/katsute/mal4j/Json.java

+                                                  try{
+                                                      list.add(Integer.parseInt(V));
+                                                  }catch(final NumberFormatException ignored){
+                                                      list.add(Long.parseLong(V));

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException

Potential uncaught 'java.lang.NumberFormatException'.

src/main/java/dev/katsute/mal4j/Json.java

+                                                  try{
+                                                      list.add(Double.parseDouble(V));
+                                                  }catch(final NumberFormatException ignored){
+                                                      list.add(Long.parseLong(V));

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException

Potential uncaught 'java.lang.NumberFormatException'.

src/main/java/dev/katsute/mal4j/Json.java

+                                                  try{
+                                                      obj.set(K, Integer.parseInt(V));
+                                                  }catch(final NumberFormatException ignored){
+                                                      obj.set(K, Long.parseLong(V));

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException

Potential uncaught 'java.lang.NumberFormatException'.

src/main/java/dev/katsute/mal4j/Json.java

+                                                  try{
+                                                      obj.set(K, Double.parseDouble(V));
+                                                  }catch(final NumberFormatException ignored){
+                                                      obj.set(K, Long.parseLong(V));

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException

Potential uncaught 'java.lang.NumberFormatException'.


          optimize number parsing

5db13ed

Katsute marked this pull request as ready for review

February 12, 2023 17:59

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view


          fix escape toggle, carriage return

c7e4645

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

ghost previously approved these changes

View reviewed changes

ghost left a comment

@Katsute I have approved this pull request


          Update TestMangaListStatus.java

ba711f6

Katsute dismissed ghost ’s stale review via

ba711f6

February 13, 2023 22:48

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view


          Update TestMangaListStatus.java

daae9ff

This comment has been minimized.

Sign in to view

ghost approved these changes

View reviewed changes

ghost left a comment

@Katsute I have approved this pull request

Katsute merged commit 4d26ace into main

Katsute deleted the json-optimization@b6517ca branch

February 14, 2023 01:47

ghost locked and limited conversation to collaborators

Katsute changed the title ~~JSON optimizations~~ JSON parsing optimizations

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels