Change groupid #355
Merged
Change groupid #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 7, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -35,7 +35,7 @@ | |||
| * @version 1.0.0 | |||
| * @author Katsute | |||
| */ | |||
| public interface FullMediaItem<MediaType extends Enum<?>,Status extends Enum<?>,ListStatus extends com.kttdevelopment.mal4j.property.ListStatus<?>,Recommendation extends com.kttdevelopment.mal4j.property.Recommendation,Statistics extends com.kttdevelopment.mal4j.property.Statistics> extends MediaItem<MediaType,Status,ListStatus> { | |||
| public interface FullMediaItem<MediaType extends Enum<?>,Status extends Enum<?>,ListStatus extends dev.katsute.mal4j.property.ListStatus<?>,Recommendation extends dev.katsute.mal4j.property.Recommendation,Statistics extends dev.katsute.mal4j.property.Statistics> extends MediaItem<MediaType,Status,ListStatus> { | |||
Check notice
Code scanning / CodeQL
Class has same name as super class
| @@ -35,7 +35,7 @@ | |||
| * @version 1.0.0 | |||
| * @author Katsute | |||
| */ | |||
| public interface FullMediaItem<MediaType extends Enum<?>,Status extends Enum<?>,ListStatus extends com.kttdevelopment.mal4j.property.ListStatus<?>,Recommendation extends com.kttdevelopment.mal4j.property.Recommendation,Statistics extends com.kttdevelopment.mal4j.property.Statistics> extends MediaItem<MediaType,Status,ListStatus> { | |||
| public interface FullMediaItem<MediaType extends Enum<?>,Status extends Enum<?>,ListStatus extends dev.katsute.mal4j.property.ListStatus<?>,Recommendation extends dev.katsute.mal4j.property.Recommendation,Statistics extends dev.katsute.mal4j.property.Statistics> extends MediaItem<MediaType,Status,ListStatus> { | |||
Check notice
Code scanning / CodeQL
Class has same name as super class
| } | ||
| }); | ||
|
|
||
| private final Integer year = requireNonNull(() -> Integer.valueOf(parts[0])); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
| }); | ||
|
|
||
| private final Integer year = requireNonNull(() -> Integer.valueOf(parts[0])); | ||
| private final Integer month = requireNonNull(() -> Integer.valueOf(parts[1])); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
|
|
||
| private final Integer year = requireNonNull(() -> Integer.valueOf(parts[0])); | ||
| private final Integer month = requireNonNull(() -> Integer.valueOf(parts[1])); | ||
| private final Integer day = requireNonNull(() -> Integer.valueOf(parts[2])); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Issues must meet the following criteria:
GitHub Copilot Disclaimer
The use of GitHub Copilot is strictly prohibited on this repository.
Changes Made
List any changes made and/or other relevant issues.
com.kttdevelopment→dev.katsuteWF-3897071556
Release Notes
🛑 This major update includes breaking changes 🛑
com.kttdevelopmenttodev.katsutecom.kttdevelopmenttodev.katsutecom.kttdevelopment.mal4jtodev.katsute.mal4j.exceptionsNullableDateinstead of aDateTo bring your code up to date:
com.kttdevelopmenttodev.katsuteimport com.kttdevelopment.mal4jwithimport dev.katsute.mal4jdev.katsute.mal4j.exceptions, fix this import manually