Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using experimental features without enabling them will now throw an exception #346

Merged
merged 4 commits into from
Sep 24, 2022

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Sep 19, 2022

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

GitHub Copilot Disclaimer

The use of GitHub Copilot is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot.

Changes Made

List any changes made and/or other relevant issues.

  • Throw exception if experimental feature is used without enabling

WF-3109844729

Release Notes

  • Using an experimental feature without enabling it will throw a ExperimentalFeatureException, previously would only print a warning

@Katsute Katsute self-assigned this Sep 19, 2022
@Katsute Katsute added this to the 2.11.0 milestone Sep 20, 2022
@Katsute Katsute marked this pull request as ready for review September 20, 2022 01:22
@Katsute
Copy link
Member Author

Katsute commented Sep 22, 2022

Experimental feature is needed for tests and method is needed to disable them to not conflict with the experimental tests

@Katsute
Copy link
Member Author

Katsute commented Sep 22, 2022

Revert comment removal in test

@Katsute
Copy link
Member Author

Katsute commented Sep 23, 2022

@mashiro-san dispatch workflow mal_ci

@ghost
Copy link

ghost commented Sep 23, 2022

@Katsute I have dispatched the workflow mal_ci.yml for branch throw-experimental@8d86650

@Katsute
Copy link
Member Author

Katsute commented Sep 23, 2022

@mashiro-san approve this pull request

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katsute I have approved this pull request

@Katsute Katsute merged commit 9389bc2 into main Sep 24, 2022
@Katsute Katsute deleted the throw-experimental@8d86650 branch September 24, 2022 01:52
@ghost ghost locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant