Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated authentication methods #345

Merged
merged 4 commits into from
Sep 24, 2022
Merged

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Sep 19, 2022

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

GitHub Copilot Disclaimer

The use of GitHub Copilot is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot.

Changes Made

List any changes made and/or other relevant issues.

  • Removed deprecated auth methods

WF-3107700449

Release Notes

  • Removed withOAuthToken, use withToken
  • Removed refreshOAuthToken, use refreshToken
  • Removed withAuthorization, use withOAuth2
  • The deprecated String parameter has been replaced with the Authorization parameter.
    Previously:
    new MyAnimeListAuthenticator("client_id", "client_secret", "authorization_code", "PKCE_code_challenge");
    Should be replaced with:
    new MyAnimeListAuthenticator(new Authorization("client_id", "client_secret", "authorization_code", "PKCE_code_challenge"));
    If you were not already using this new object before, an access token can be passed to this method to use an existing token, rather than generating a new one:
    new MyAnimeListAuthenticator(new Authorization(...), new AccessToken("access_token");
    new MyAnimeListAuthenticator(new Authorization(...), new AccessToken("access_token", "refresh_token");
    new MyAnimeListAuthenticator(new Authorization(...), new AccessToken("access_token", "refresh_token", 1640995200);

@Katsute Katsute self-assigned this Sep 19, 2022
@Katsute Katsute added this to the 2.11.0 milestone Sep 20, 2022
@Katsute Katsute marked this pull request as ready for review September 20, 2022 01:24
@Katsute Katsute changed the title Remove deprecated string authenticator Remove deprecated authentication methods Sep 22, 2022
@Katsute
Copy link
Member Author

Katsute commented Sep 22, 2022

@mashiro-san dispatch workflow mal_ci

@ghost
Copy link

ghost commented Sep 22, 2022

@Katsute I have dispatched the workflow mal_ci.yml for branch deprecated-auth@8d86650

@Katsute
Copy link
Member Author

Katsute commented Sep 22, 2022

@mashiro-san approve this pull request

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katsute I have approved this pull request

@Katsute Katsute merged commit cadbb90 into main Sep 24, 2022
@Katsute Katsute deleted the deprecated-auth@8d86650 branch September 24, 2022 01:52
@ghost ghost locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant