Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Anime PV/Trailers #341

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Added Anime PV/Trailers #341

merged 3 commits into from
Sep 7, 2022

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Sep 7, 2022

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

GitHub Copilot Disclaimer

The use of GitHub Copilot is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot.

Changes Made

List any changes made and/or other relevant issues.

WF-3004377200

Release Notes

  • Retrieve Anime PVs/Trailers using Anime.getVideos(), returns an array
  • Added corresponding field variable videos or Fields.Anime.videos
  • Added corresponding experimental field ExperimentalFeature.VIDEOS

@@ -254,6 +254,73 @@
};
}

static Video asVideo(final MyAnimeList mal, final JsonObject schema){

Check notice

Code scanning / CodeQL

Useless parameter

The parameter mal is unused.
@@ -218,7 +218,7 @@
};
}

static EndingTheme asEndingTheme(final MyAnimeList mal, final JsonObject schema, Anime anime){
static EndingTheme asEndingTheme(final MyAnimeList mal, final JsonObject schema, final Anime anime){

Check notice

Code scanning / CodeQL

Useless parameter

The parameter mal is unused.
@@ -182,7 +182,7 @@
};
}

static OpeningTheme asOpeningTheme(final MyAnimeList mal, final JsonObject schema, Anime anime){
static OpeningTheme asOpeningTheme(final MyAnimeList mal, final JsonObject schema, final Anime anime){

Check notice

Code scanning / CodeQL

Useless parameter

The parameter mal is unused.
@Katsute Katsute linked an issue Sep 7, 2022 that may be closed by this pull request
@Katsute Katsute changed the title Add Anime PV/Trailers Added Anime PV/Trailers Sep 7, 2022
@Katsute
Copy link
Member Author

Katsute commented Sep 7, 2022

@mashiro-san dispatch workflow mal_ci

@ghost
Copy link

ghost commented Sep 7, 2022

@Katsute I have dispatched the workflow mal_ci.yml for branch videos@d7a8127

@Katsute
Copy link
Member Author

Katsute commented Sep 7, 2022

@mashiro-san approve this pull

ghost
ghost previously approved these changes Sep 7, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katsute I have approved this pull request

@Katsute
Copy link
Member Author

Katsute commented Sep 7, 2022

@mashiro-san approve this pull

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katsute I have approved this pull request

@Katsute Katsute merged commit 433f891 into main Sep 7, 2022
@Katsute Katsute deleted the videos@d7a8127 branch September 7, 2022 01:39
@ghost ghost locked and limited conversation to collaborators Sep 7, 2022
@Katsute Katsute added this to the 2.10.0 milestone Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undocumented videos field
1 participant