Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginated iterator now returns a modifiable list instead of an unmodifiable one #337

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Paginated iterator now returns a modifiable list instead of an unmodifiable one #337

merged 1 commit into from
Sep 2, 2022

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Sep 2, 2022 •
edited by ghost
Loading

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

GitHub Copilot Disclaimer

The use of GitHub Copilot is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot.

Changes Made

List any changes made and/or other relevant issues.

  • Made paginated iterator toList return a new list instead of an unmodifiable one.
  • Made paginated iterator toSet return a new set instead of an unmodifiable one.
  • Documentation changes.
  • Test changes.

WF-2981809091

@Katsute Katsute self-assigned this Sep 2, 2022
@Katsute
Copy link
Member Author

Katsute commented Sep 2, 2022

@mashiro-san dispatch workflow mal_ci

@ghost
Copy link

ghost commented Sep 2, 2022

@Katsute I have dispatched the workflow mal_ci.yml for branch modify-iterator@ec25b42

@Katsute
Copy link
Member Author

Katsute commented Sep 2, 2022

@mashiro-san approve this pull

ghost
ghost approved these changes Sep 2, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katsute I have approved this pull request

@Katsute Katsute merged commit 89af930 into main Sep 2, 2022
@Katsute Katsute deleted the modify-iterator@ec25b42 branch September 2, 2022 21:13
@ghost ghost locked and limited conversation to collaborators Sep 2, 2022
@Katsute Katsute added this to the 2.10.0 milestone Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees

@Katsute Katsute

Labels
feature request
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Katsute