Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing relation types #320

Merged
merged 3 commits into from
Jul 17, 2022
Merged

Add missing relation types #320

merged 3 commits into from
Jul 17, 2022

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Jul 17, 2022 •
edited by ghost
Loading

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

GitHub Copilot Disclaimer

The use of GitHub Copilot is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot.

Changes Made

List any changes made and/or other relevant issues.

  • Add missing relation type 'spin off' and 'character'
  • Return unknown relation type rather than null

WF-2686336649

Release Notes

  • Add missing relation type Spin off
  • Add missing relation type Character
  • For unknown relation type return Unknown rather than null

@Katsute Katsute added the bug label Jul 17, 2022
@Katsute Katsute self-assigned this Jul 17, 2022
@Katsute
Copy link
Member Author

Katsute commented Jul 17, 2022

@mashiro-san dispatch workflow mal_ci

@ghost
Copy link

ghost commented Jul 17, 2022

@Katsute I have dispatched the workflow mal_ci.yml for branch missing-enums@1b99787

@Katsute
Copy link
Member Author

Katsute commented Jul 17, 2022

@mashiro-san dispatch workflow mal_ci

@ghost
Copy link

ghost commented Jul 17, 2022

@Katsute I have dispatched the workflow mal_ci.yml for branch missing-enums@1b99787

@Katsute
Copy link
Member Author

Katsute commented Jul 17, 2022

@mashiro-san approve this pull please

ghost
ghost approved these changes Jul 17, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katsute I have approved this pull request

@Katsute Katsute merged commit 0bcc6b7 into main Jul 17, 2022
@Katsute Katsute deleted the missing-enums@1b99787 branch July 17, 2022 20:26
@ghost ghost locked and limited conversation to collaborators Jul 17, 2022
@Katsute Katsute added this to the 2.8.0 milestone Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees

@Katsute Katsute

Labels
bug
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Katsute