Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing hiatus, web novel, and mixed media enums #312

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Jun 6, 2022

Prerequisites

If checks are not passed then the pull request will be closed.

  • I have checked that no other similar pull request already exists.
  • My code follows the general code style as the rest of the code.
  • I have checked that no sensitive information is exposed.
  • Build compiles.
  • Build passes test cases.

GitHub Copilot Disclaimer

The use of GitHub Copilot is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot.

Changes Made

List any changes made and/or other relevant issues.

  • Add missing Manga status OnHiatus
  • Add missing Anime source MixedMedia, WebNovel
  • Add missing Unknown type
  • Rename Anime source Digital_Manga → DigitalManga
  • Rename Anime source Web_Manga → WebManga
  • Fallback to unknown rather than null

https://github.com/KatsuteDev/Mal4J/actions/runs/2449424775

@Katsute
Copy link
Member Author

Katsute commented Jun 6, 2022

@sinon-bot dispatch mal_ci

@ghost
Copy link

ghost commented Jun 6, 2022

🚀 Dispatched Workflow

Dispatched workflow mal_ci.yml on branch undocumented@485876c

This workflow was dispatched by @Katsute.

@Katsute Katsute linked an issue Jun 6, 2022 that may be closed by this pull request
6 tasks
@Katsute
Copy link
Member Author

Katsute commented Jun 6, 2022

@sinon-bot dispatch mal_ci

@ghost
Copy link

ghost commented Jun 6, 2022

🚀 Dispatched Workflow

Dispatched workflow mal_ci.yml on branch undocumented@485876c

This workflow was dispatched by @Katsute.

@Katsute
Copy link
Member Author

Katsute commented Jun 6, 2022

@sinon-bot approve

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Pull Approved

This pull was approved by @Katsute.

@Katsute Katsute enabled auto-merge (squash) June 6, 2022 18:08
@Katsute Katsute merged commit 0f66642 into main Jun 6, 2022
@Katsute Katsute deleted the undocumented@485876c branch June 6, 2022 18:10
@ghost ghost locked and limited conversation to collaborators Jun 6, 2022
@Katsute Katsute added this to the 2.8.0 milestone Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undocumented statuses/sources
1 participant