Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception for invalid or expired token #209

Merged
merged 5 commits into from
Aug 11, 2021
Merged

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Aug 3, 2021

Prerequisites

If all checks are not passed then the pull request will be closed.

  • I have checked that no other similar pull request already exists.
  • My code follows the general code style as the rest of the code.
  • I have checked that no sensitive information is exposed.
  • Build compiles.
  • Build passes test cases.
  • I have added/modified documentation (check if not applicable).
  • I have added/modified test cases (check if not applicable).

Workflow Run: The link to the MyAnimeList CI workflow run for your branch. Check README for guide on remote tests.
https://github.com/Katsute/Mal4J/actions/runs/1117529501

Changes Made

List any changes made and/or other relevant issues.

  • added exception for invalid or expired token

@Katsute Katsute added this to the 2.3.0 milestone Aug 3, 2021
@Katsute Katsute self-assigned this Aug 3, 2021
@Katsute
Copy link
Member Author

Katsute commented Aug 4, 2021

@Katsute
Copy link
Member Author

Katsute commented Aug 10, 2021

Assumption should be changed to only skip test on CI

@Katsute
Copy link
Member Author

Katsute commented Aug 10, 2021

@Sinon-bot approve test cases passed

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @Katsute

test cases passed

@Katsute Katsute merged commit 10c87c3 into main Aug 11, 2021
@ghost ghost locked and limited conversation to collaborators Aug 11, 2021
@Katsute Katsute deleted the invalid-token@21eb768 branch August 11, 2021 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant