Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Genre #161

Merged
merged 4 commits into from
Apr 11, 2021
Merged

Fix Genre #161

merged 4 commits into from
Apr 11, 2021

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Apr 10, 2021

⚠ DEVELOPER NOTICE:

  • Genre#asEnum is now deprecated. Use Genre#asAnimeGenre or Genre#asMangaGenre.
  • Genre#getId is now deprecated. Use Genre#getAnimeGenreID or Genre#getMangaGenreID.
  • Anime/Manga genres are not sorted alphabetically, they are ordered by genre ID.

Prerequisites

If all checks are not passed then the pull request will be closed.

  • I have checked that no other similar pull request already exists.
  • My code follows the general code style as the rest of the code.
  • I have checked that no sensitive information is exposed.
  • Build compiles.
  • Build passes test cases.
  • I have added/modified documentation (if applicable).
  • I have added/modified test cases (if applicable).

Issue: The main issue(s) that this pull request fixes.
#158, #159, #160

Workflow Run: The link to the MyAnimeList CI workflow run for your branch. Check README for guide on remote tests.
https://github.com/Katsute/Mal4J/actions/runs/737054101

Changes Made

List any changes made and/or other relevant issues.

@Katsute Katsute self-assigned this Apr 10, 2021
@Katsute Katsute merged commit ef69e23 into main Apr 11, 2021
@Katsute Katsute deleted the enum@e37355a branch April 11, 2021 00:43
Katsute added a commit that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anime genres do not match Manga genres Missing Genre enums Genre enum is mapped incorrectly
1 participant