Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow defining where to get ssh keys and where to store them #281

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Dec 18, 2018

--rex-proxies: Comma separated list of Proxies to install Foreman's
SSH keys for remote execution. It will iterate all over the list of
capsules. If one fails user is notified by the task keeps going until
all proxies were tried.

--rex-urlkeyfile: HTTP/S location to install a file containing one or
multiple Foreman's SSH keys for remote execution. Instead of iterate
you can create file on /pub folder that contains all ssh public keys
of several capsules and tell bootstrap.py to fech it and install on
the local user authorized keys file.

--rex-authpath. Local folder where is placed the authorized_keys file
to install Foreman's SSH keys for remote execution. Default ~/.ssh.
I found that several customers specifies AuthorizedKeysFile on
sshd_config on a different path.

Closes: #204
Closes: #210

Authored-by: Alberto Losada alosadag@redhat.com
Rebased-by: Evgeni Golov evgeni@golov.de
Rebased-by: François Cami fcami@fedoraproject.org

@fcami
Copy link
Contributor

fcami commented Dec 18, 2018

LGTM @evgeni

Copy link
Member

@sideangleside sideangleside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add an example use-case in README.md like we do for all new options. Otherwise, this LGTM.

--rex-proxies: Comma separated list of Proxies to install Foreman's
SSH keys for remote execution. It will iterate all over the list of
capsules. If one fails user is notified by the task keeps going until
all proxies were tried.

--rex-urlkeyfile: HTTP/S location to install a file containing one or
multiple Foreman's SSH keys for remote execution. Instead of iterate
you can create file on /pub folder that contains all ssh public keys
of several capsules and tell bootstrap.py to fech it and install on
the local user authorized keys file.

--rex-authpath. Local folder where is placed the authorized_keys file
to install Foreman's SSH keys for remote execution. Default ~/.ssh.
I found that several customers specifies AuthorizedKeysFile on
sshd_config on a different path.

Closes: Katello#204
Closes: Katello#210

Authored-by: Alberto Losada <alosadag@redhat.com>
Rebased-by: Evgeni Golov <evgeni@golov.de>
Rebased-by: François Cami <fcami@fedoraproject.org>
@evgeni
Copy link
Member Author

evgeni commented Dec 18, 2018

added examples, merging when tests pass

@evgeni evgeni merged commit fff3520 into Katello:master Dec 18, 2018
evgeni added a commit to evgeni/katello-client-bootstrap that referenced this pull request Jan 24, 2019
changelog:
* Python 3 support
* Capability to preserve proxy settings when reconfiguring/migrating the client (Katello#283)
* EL5 subscription manager compatibility fixes (Katello#284)
* Only yum clean metadata and dbcache, not RPMs (Katello#280)
* Allow defining where to get ssh keys and where to store them (Katello#281)
* Make the FIPS check more robust (Katello#279)
* Support yum and dnf Python bindings (Katello#271)
* Option to ignore registration failures (Katello#261)
* Force lowercase FQDN writing puppet configuration (Katello#255)
* Improve the error message when a search fails (Katello#257)
@evgeni evgeni mentioned this pull request Jan 24, 2019
evgeni added a commit that referenced this pull request Jan 25, 2019
changelog:
* Python 3 support
* Capability to preserve proxy settings when reconfiguring/migrating the client (#283)
* EL5 subscription manager compatibility fixes (#284)
* Only yum clean metadata and dbcache, not RPMs (#280)
* Allow defining where to get ssh keys and where to store them (#281)
* Make the FIPS check more robust (#279)
* Support yum and dnf Python bindings (#271)
* Option to ignore registration failures (#261)
* Force lowercase FQDN writing puppet configuration (#255)
* Improve the error message when a search fails (#257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants