-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow defining where to get ssh keys and where to store them #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2018
LGTM @evgeni |
sideangleside
approved these changes
Dec 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add an example use-case in README.md like we do for all new options. Otherwise, this LGTM.
--rex-proxies: Comma separated list of Proxies to install Foreman's SSH keys for remote execution. It will iterate all over the list of capsules. If one fails user is notified by the task keeps going until all proxies were tried. --rex-urlkeyfile: HTTP/S location to install a file containing one or multiple Foreman's SSH keys for remote execution. Instead of iterate you can create file on /pub folder that contains all ssh public keys of several capsules and tell bootstrap.py to fech it and install on the local user authorized keys file. --rex-authpath. Local folder where is placed the authorized_keys file to install Foreman's SSH keys for remote execution. Default ~/.ssh. I found that several customers specifies AuthorizedKeysFile on sshd_config on a different path. Closes: Katello#204 Closes: Katello#210 Authored-by: Alberto Losada <alosadag@redhat.com> Rebased-by: Evgeni Golov <evgeni@golov.de> Rebased-by: François Cami <fcami@fedoraproject.org>
added examples, merging when tests pass |
evgeni
added a commit
to evgeni/katello-client-bootstrap
that referenced
this pull request
Jan 24, 2019
changelog: * Python 3 support * Capability to preserve proxy settings when reconfiguring/migrating the client (Katello#283) * EL5 subscription manager compatibility fixes (Katello#284) * Only yum clean metadata and dbcache, not RPMs (Katello#280) * Allow defining where to get ssh keys and where to store them (Katello#281) * Make the FIPS check more robust (Katello#279) * Support yum and dnf Python bindings (Katello#271) * Option to ignore registration failures (Katello#261) * Force lowercase FQDN writing puppet configuration (Katello#255) * Improve the error message when a search fails (Katello#257)
Merged
evgeni
added a commit
that referenced
this pull request
Jan 25, 2019
changelog: * Python 3 support * Capability to preserve proxy settings when reconfiguring/migrating the client (#283) * EL5 subscription manager compatibility fixes (#284) * Only yum clean metadata and dbcache, not RPMs (#280) * Allow defining where to get ssh keys and where to store them (#281) * Make the FIPS check more robust (#279) * Support yum and dnf Python bindings (#271) * Option to ignore registration failures (#261) * Force lowercase FQDN writing puppet configuration (#255) * Improve the error message when a search fails (#257)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--rex-proxies: Comma separated list of Proxies to install Foreman's
SSH keys for remote execution. It will iterate all over the list of
capsules. If one fails user is notified by the task keeps going until
all proxies were tried.
--rex-urlkeyfile: HTTP/S location to install a file containing one or
multiple Foreman's SSH keys for remote execution. Instead of iterate
you can create file on /pub folder that contains all ssh public keys
of several capsules and tell bootstrap.py to fech it and install on
the local user authorized keys file.
--rex-authpath. Local folder where is placed the authorized_keys file
to install Foreman's SSH keys for remote execution. Default ~/.ssh.
I found that several customers specifies AuthorizedKeysFile on
sshd_config on a different path.
Closes: #204
Closes: #210
Authored-by: Alberto Losada alosadag@redhat.com
Rebased-by: Evgeni Golov evgeni@golov.de
Rebased-by: François Cami fcami@fedoraproject.org