[PR] Breaking Changes to DEV, Change CLA Configuration on main #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created separate directory for each of the tools. This is done to assure ease of documentation and potentially ease of testing of each of the tools separately.
This will be important when using poetry to distribute the scripts to PyPI
Briefly ran all of the tests to verify if the collection is working. Additionally, this was meant to verify it the test input and output is deleted as intended. So far the utility scriprts work as designed apart from the decorator that messed up with previous test collection attempts.
Attempt to fix the CLA bot
* Ignore PyCharm project dir * Fix Make target names in the CI * Makefile: fix Docker container name * CI: fix Python version matrix * Makefile: don't mount local directory for pre-commit checks The Docker container is built just before running this, so mounting the local files makes no sense. Because of the mount, file ownership is broken which upsets git and fails the entire pipeline. * Makefile: remove old comment from pre-commit pre-commit inside the container will return a non-zero exit code if something goes wrong, which will propagate correctly and fail the pipeline. * Makefile: fix Docker image names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CLA was set to work and save information on the
devbranch with the signatures, I am pushing this breaking change to main to attempt to fix it.@Ostrzyciel let's squash this CLA issue on
mainand call it a day, before all this is published on PyPI I think we are free to break things.