Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect selector in UiViewBuilder.withChild #574

Closed
grassydragon opened this issue Sep 20, 2023 · 0 comments · Fixed by #575
Closed

Incorrect selector in UiViewBuilder.withChild #574

grassydragon opened this issue Sep 20, 2023 · 0 comments · Fixed by #575
Labels
bug Something isn't working

Comments

@grassydragon
Copy link
Contributor

Describe the bug
The withChild function has the same body as the withDescendant function:

Kaspresso/kautomator/src/main/kotlin/com/kaspersky/components/kautomator/component/common/builders/UiViewBuilder.kt

Lines 280 to 281 in cf34c1a

fun withDescendant(function: UiViewBuilder.() -> Unit) =
addSelector { hasDescendant(UiViewBuilder().apply(function).build().bySelector) }

Kaspresso/kautomator/src/main/kotlin/com/kaspersky/components/kautomator/component/common/builders/UiViewBuilder.kt

Lines 323 to 324 in cf34c1a

fun withChild(function: UiViewBuilder.() -> Unit) =
addSelector { hasDescendant(UiViewBuilder().apply(function).build().bySelector) }

Expected behavior
It looks like the hasChild selector should be used: https://developer.android.com/reference/androidx/test/uiautomator/BySelector#hasChild(androidx.test.uiautomator.BySelector)
@grassydragon grassydragon added the bug Something isn't working label Sep 20, 2023
grassydragon added a commit to grassydragon/Kaspresso that referenced this issue Sep 20, 2023
@grassydragon
Issue KasperskyLab#574: Use correct selector in withChild
8112833
@AzamatCherchesov AzamatCherchesov linked a pull request Oct 9, 2023 that will close this issue
Issue #574: Use correct selector in withChild #575
Merged
AzamatCherchesov pushed a commit that referenced this issue Oct 9, 2023
@grassydragon
Issue #574: Use correct selector in withChild (#575)
0fa58e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #574: Use correct selector in withChild grassydragon/Kaspresso
1 participant
@grassydragon