Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmakelists changes #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

cmakelists changes #70

wants to merge 2 commits into from

Conversation

shengjianda
Copy link

  1. add prefix for options
  2. auto create metis.h from metis.h.in depends on cmake setting of METIS_IDX64 and METIS_REAL64,
  3. metis can be used as submodule for other projects

@LecrisUT
Copy link

LecrisUT commented Oct 26, 2023 •
edited
Loading

Hey @shengjianda I have some pointers about CMake modernization. Can we collaborate a bit to make this project more usable? I will submit a few PRs on your forks with

  • Github Actions so that we can validate the builds a bit
  • Update the minimum requirement to at least 3.11 to use FetchContent (technically we should go for 3.24 to make use of FIND_PACKAGE_ARGS, but I have a simple backport for that that we can use)
  • Add CMake packaging
  • General reorganization to make things readable (see my approach in the spglib and octopus packaging)

See #79. Working on the equivalent for GKlib tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shengjianda @LecrisUT