Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid JSON in strings.json file #1565

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hpuac
Copy link
Contributor

@hpuac hpuac commented Jan 11, 2025

Motivation:

Within #1488 a small mistake sneaked into the strings.json file.
Since then the JSON file is invalid, a simple comma is missing.

Changes:

This cahnge will add the missing comma to make the JSON file valid again.

Related issue (check one):

  • fixes #
  • There is no related issue ticket

Checklist (check one):

  • I did not change any code (e.g. documentation changes)
  • The code change is tested and works locally.

Test-Hardware list (for code changes)

HA Version:
Zigbee2MQTT Version:
TRV Hardware:

New device mappings

  • I avoided any changes to other device mappings
  • There are no changes in climate.py

@folfy
Copy link
Collaborator

folfy commented Jan 12, 2025

Also need to consider if the strings.json is rly used or needed, since we have the translations and it's just a duplicate of the en file. At least should make it a symlink otherwise I'd say. But PR is fine, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants