hvac_action attribute stays in "heating" state even if Better Thermostat is turned off #1340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove check for an empty hvac_action
Motivation:
This is in relation to #1193 , after the changes made previously in this thread were made and 1.5 was released. I still have HVAC_action staying as heating, when the device state is off and the set temp is higher than current temp.
Changes:
Remove a check for the current hvac_action to be none before the rest of the normal logic kicks in.
Related issue (check one):
Checklist (check one):