-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small-than implementation in counters as translation into new "inverted counter" #679
Conversation
63d7608
to
686c6d3
Compare
686c6d3
to
e4b6fe8
Compare
Does this change anything besides adding the "lesser than" testing capacity? I maintain a parser/analyzer at https://github.com/hmedina/KaSaAn which I'll need to update, so I'm just wondering if there's more to it or just this. |
Hey :-) Not sure how you manage counters there. If there are no It seems like KaSaAn is based on parsing snapshots ? It is likely we add a new logic that will remove this new counter for the rule condition to work. Does that answer your question? |
Hey there! Ok, if snapshots won't contain this new construct, only rules, then I don't need to update my parsing yet, as the "real" thing in the snapshot should parse fine. Will contact maps have the rule's definition ( |
In this PR, after the parsing of the Everything should work fine on your end. |
…ed counter" (#679) * Code cleanup in counters_compiler * Added translation from CLTE to CGTE * Test for <= in counters * fix ci
Hello @hmedina , after discussion with @feret , we actually are hiding these counters now in snapshots since this recent commit Sorry for the worry about this! |
Allows
<=
tests in a agent counter.Using
<=
will enable in parallel a hidden inverted counter where the>=
test will be made.Counter logic is planned to be revamped to allow this naturally.
Example of use:
Here, a counter
c__inverted
is added onto agentA
, which manages the<=
tests.