fix(1094): Keep current visibility when adding a new entity to the ca…

[tplevko]

…nvas

fixes #1094

vokoscreenNG-2024-11-13_15-03-55.mp4

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.47%. Comparing base (d3299a6) to head (818e414).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...sualization/ContextToolbar/NewEntity/NewEntity.tsx	57.14%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1615      +/-   ##
============================================
- Coverage     78.48%   78.47%   -0.02%     
  Complexity      367      367              
============================================
  Files           468      468              
  Lines         14778    14784       +6     
  Branches       2746     2831      +85     
============================================
+ Hits          11599    11602       +3     
- Misses         3091     3094       +3     
  Partials         88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lordrip]

@tplevko we now have the getVisualizationNodesFromGraph function to look for canvas nodes.

      setTimeout(() => {
        const result = getVisualizationNodesFromGraph(
          controller.getGraph(),
          (vizNode) => vizNode.data.entity?.id === newId,
        );

        controller.fireEvent(SELECTION_EVENT, [result[0]?.id]);
      }, 300);

That being said, I don't know a better way to ensure the selection happens after the rerender 😢 , so probably what's gonna happen for environments like DevSpaces, this might fail from time to time, since the SELECTION_EVENT could happen before the actual rerender.

Would you be open to moving forward without the setTimeout for now until we get a better way to ensure the entity is properly selected?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud