Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Rath Filter Slider cannot move #133

Closed
ObservedObserver opened this issue Sep 21, 2022 · 1 comment
Closed

[BUG] Rath Filter Slider cannot move #133

ObservedObserver opened this issue Sep 21, 2022 · 1 comment

Comments

@ObservedObserver
Copy link
Member

ObservedObserver commented Sep 21, 2022 •
edited
Loading

image

  • slider interaction bug
  • filter i18n
ObservedObserver added a commit that referenced this issue Sep 22, 2022
@ObservedObserver
Merge pull request #134 from AntoineYANG/fix-rath_client-slider_canno…
f67402e 
…t_drag-yzd-0922

Fix #133 rath client slider cannot drag & i18n
@AntoineYANG
Copy link
Contributor

In this case RangeSelector component which includes a Slider failed to behaviour when it receives string values as props.

At the page of DataSource, users will interact while only RAW data visible to them, some fields which will be marked as quantitative, transformed from strings to numbers, is string instances at that time. Type check and safe parsing should be attached to make sure that string values will not be passed to the RangeSelector component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ObservedObserver @AntoineYANG