Fix tokenizer positions when multiple newlines follow eachother #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kampfkarren
reviewed
Feb 25, 2023
| @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Fixed parse failed with Chinese token in comment and bump deps. | |||
| - Added `first` method to `Punctuated`. | |||
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in
read_positionwhen multiple newlines follow each other, which manifests into the errors seen in https://github.com/evaera/moonwave/actions/runs/3990359990/jobs/6843912815This is because the line number is not bumped for consecutive newline characters, it is only bumped once a non-newline character is seen.
We fix this by always bumping when
has_newlineis set, then checking afterwards for the\ncharacter and settinghas_newline = true