temperature_mcu: add reference_voltage #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for boards that don't run their ADC with 3.3V to output accurate MCU temperature readings. Signed-off-by: Peter Stehrer <peter.stehrer@cloudflight.io>
dalegaard
force-pushed
the
ikirin-mcu-reference-voltage
branch
from
2e75899 to
130e39a
Compare
rogerlz
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for boards that don't run their ADC with 3.3V to output accurate MCU temperature readings.
This was originally posted in Klipper3d/klipper#5713 but was rejected by mainline.
The code was written by iKirin of Annex Engineering. With his permission, I've cleaned it up a bit, added a few missing cases and formatted it with Black.
The use case for this is especially rp2040 boards with accurate ADC references. Because of how the Pico board is set up, getting a stable reference is only possible by pulling the reference down to 3.0V. Without this patch, a 3.3V reference is assumed.