Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update input tokens to pine #2061

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

QuintonJason
Copy link
Contributor

@QuintonJason QuintonJason commented Feb 10, 2025

Description

Convert Sage Input tokens to Pine

Testing in sage-lib

Visit Input view and Input group view
Verify updated tokens

Testing in kajabi-products

  1. (LOW) (LOW) Converts input tokens to Pine

Related

Closes DSS-1259

@QuintonJason QuintonJason self-assigned this Feb 11, 2025
@QuintonJason QuintonJason changed the title Style/input tokens style: update input tokens to pine Feb 11, 2025
@QuintonJason QuintonJason marked this pull request as ready for review February 11, 2025 23:40
@QuintonJason QuintonJason requested a review from a team February 11, 2025 23:40
@pixelflips pixelflips requested a review from a team February 11, 2025 23:43
Copy link
Contributor

@anechol anechol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking, but can we also get the mixin sage-form-field-message updated? We have tokens for input helper message text available.

@QuintonJason QuintonJason merged commit 446ad6a into chore/sage-pine-visual-parity Feb 13, 2025
4 checks passed
@QuintonJason QuintonJason deleted the style/input-tokens branch February 13, 2025 21:51
QuintonJason added a commit that referenced this pull request Feb 19, 2025
* chore: adds Pine packages to repo

* chore: updates Pine stylesheet link to latest version

* style: update progress tokens to pine (#2050)

* style: update checkbox tokens to pine (#2052)

* style: update tokens

* style: hello linter my old friend

* style: hello linter my old friend

* style: revert z-index changes

* style: update sortable tokens to pine (#2059)

* style: update textarea tokens to pine (#2055)

* style: update loader tokens to pine (#2056)

* style: update tokens and success colors

* style: add missing semicolon

* style: revert z-index changes

* fix: adjust font weight of text

* style: updates avatar styles and tokens (#2051)

* style: updates avatar styles and tokens

* chore: updates default icon for React component

* style(avatar): move from sage to pine tokens

* chore: updates core tokens to semantic where possible

* chore: swaps out React stencil component for web component version

* style: update table tokens to pine (#2057)

* style: update tokens

* style: add calc comment

* style: updates button styles to match Pine (#2058)

* style: updates button styles to match Pine

* style: updates copytext component to match Pine

* chore: fixes linting

* style: update tabs tokens to pine (#2060)

* style: update tokens

* style: correct bg color

* style: update popover tokens to pine (#2062)

* style: update input tokens to pine (#2061)

* style: update input tokens

* style: update sage variables to pine

* style: add missing tokens

* style: reorder CSS props

* style: update sage form field message vars

* style: update switch tokens (#2053)

* style: update tokens

* style: hello linter my old friend

* style: hello linter my old friend

* style: update switch tokens

* style: update sage tokens

* style: updated var

---------

Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>

* chore: adds Pine css to imports

* style: update select tokens to pine (#2063)

* style: update tokens

* fix: update icon and color

* style: hello linter my old friend

* fix: hello linter my old friend

* style: updates Badge styles to match Pine Chip (#2064)

* style: updates Badge styles to match Pine Chip

* chore: style linting

* style: update radio tokens (#2054)

* style: update tokens

* style: hello linter my old friend

* style: hello linter my old friend

* style: update radio tokens

* style: update sage token values

* style: add error and checked vars

---------

Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>

* style: updates Tooltip tokens to match Pine (#2067)

---------

Co-authored-by: Ashley Echols <ashley.echols@kajabi.com>
Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>
QuintonJason added a commit that referenced this pull request Feb 19, 2025
* chore: adds Pine packages to repo

* chore: updates Pine stylesheet link to latest version

* style: update progress tokens to pine (#2050)

* style: update checkbox tokens to pine (#2052)

* style: update tokens

* style: hello linter my old friend

* style: hello linter my old friend

* style: revert z-index changes

* style: update sortable tokens to pine (#2059)

* style: update textarea tokens to pine (#2055)

* style: update loader tokens to pine (#2056)

* style: update tokens and success colors

* style: add missing semicolon

* style: revert z-index changes

* fix: adjust font weight of text

* style: updates avatar styles and tokens (#2051)

* style: updates avatar styles and tokens

* chore: updates default icon for React component

* style(avatar): move from sage to pine tokens

* chore: updates core tokens to semantic where possible

* chore: swaps out React stencil component for web component version

* style: update table tokens to pine (#2057)

* style: update tokens

* style: add calc comment

* style: updates button styles to match Pine (#2058)

* style: updates button styles to match Pine

* style: updates copytext component to match Pine

* chore: fixes linting

* style: update tabs tokens to pine (#2060)

* style: update tokens

* style: correct bg color

* style: update popover tokens to pine (#2062)

* style: update input tokens to pine (#2061)

* style: update input tokens

* style: update sage variables to pine

* style: add missing tokens

* style: reorder CSS props

* style: update sage form field message vars

* style: update switch tokens (#2053)

* style: update tokens

* style: hello linter my old friend

* style: hello linter my old friend

* style: update switch tokens

* style: update sage tokens

* style: updated var

---------

Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>

* chore: adds Pine css to imports

* style: update select tokens to pine (#2063)

* style: update tokens

* fix: update icon and color

* style: hello linter my old friend

* fix: hello linter my old friend

* style: updates Badge styles to match Pine Chip (#2064)

* style: updates Badge styles to match Pine Chip

* chore: style linting

* style: update radio tokens (#2054)

* style: update tokens

* style: hello linter my old friend

* style: hello linter my old friend

* style: update radio tokens

* style: update sage token values

* style: add error and checked vars

---------

Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>

* style: updates Tooltip tokens to match Pine (#2067)

---------

Co-authored-by: Ashley Echols <ashley.echols@kajabi.com>
Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>
QuintonJason added a commit that referenced this pull request Feb 19, 2025
* chore(tokens): sage pine visual parity (#2070)

* chore: adds Pine packages to repo

* chore: updates Pine stylesheet link to latest version

* style: update progress tokens to pine (#2050)

* style: update checkbox tokens to pine (#2052)

* style: update tokens

* style: hello linter my old friend

* style: hello linter my old friend

* style: revert z-index changes

* style: update sortable tokens to pine (#2059)

* style: update textarea tokens to pine (#2055)

* style: update loader tokens to pine (#2056)

* style: update tokens and success colors

* style: add missing semicolon

* style: revert z-index changes

* fix: adjust font weight of text

* style: updates avatar styles and tokens (#2051)

* style: updates avatar styles and tokens

* chore: updates default icon for React component

* style(avatar): move from sage to pine tokens

* chore: updates core tokens to semantic where possible

* chore: swaps out React stencil component for web component version

* style: update table tokens to pine (#2057)

* style: update tokens

* style: add calc comment

* style: updates button styles to match Pine (#2058)

* style: updates button styles to match Pine

* style: updates copytext component to match Pine

* chore: fixes linting

* style: update tabs tokens to pine (#2060)

* style: update tokens

* style: correct bg color

* style: update popover tokens to pine (#2062)

* style: update input tokens to pine (#2061)

* style: update input tokens

* style: update sage variables to pine

* style: add missing tokens

* style: reorder CSS props

* style: update sage form field message vars

* style: update switch tokens (#2053)

* style: update tokens

* style: hello linter my old friend

* style: hello linter my old friend

* style: update switch tokens

* style: update sage tokens

* style: updated var

---------

Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>

* chore: adds Pine css to imports

* style: update select tokens to pine (#2063)

* style: update tokens

* fix: update icon and color

* style: hello linter my old friend

* fix: hello linter my old friend

* style: updates Badge styles to match Pine Chip (#2064)

* style: updates Badge styles to match Pine Chip

* chore: style linting

* style: update radio tokens (#2054)

* style: update tokens

* style: hello linter my old friend

* style: hello linter my old friend

* style: update radio tokens

* style: update sage token values

* style: add error and checked vars

---------

Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>

* style: updates Tooltip tokens to match Pine (#2067)

---------

Co-authored-by: Ashley Echols <ashley.echols@kajabi.com>
Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>

* style(form-select): simplify the calculation

---------

Co-authored-by: Ashley Echols <ashley.echols@kajabi.com>
Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>
Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
ju-Skinner pushed a commit that referenced this pull request Feb 19, 2025
* chore: adds Pine packages to repo

* chore: updates Pine stylesheet link to latest version

* style: update progress tokens to pine (#2050)

* style: update checkbox tokens to pine (#2052)

* style: update tokens

* style: hello linter my old friend

* style: hello linter my old friend

* style: revert z-index changes

* style: update sortable tokens to pine (#2059)

* style: update textarea tokens to pine (#2055)

* style: update loader tokens to pine (#2056)

* style: update tokens and success colors

* style: add missing semicolon

* style: revert z-index changes

* fix: adjust font weight of text

* style: updates avatar styles and tokens (#2051)

* style: updates avatar styles and tokens

* chore: updates default icon for React component

* style(avatar): move from sage to pine tokens

* chore: updates core tokens to semantic where possible

* chore: swaps out React stencil component for web component version

* style: update table tokens to pine (#2057)

* style: update tokens

* style: add calc comment

* style: updates button styles to match Pine (#2058)

* style: updates button styles to match Pine

* style: updates copytext component to match Pine

* chore: fixes linting

* style: update tabs tokens to pine (#2060)

* style: update tokens

* style: correct bg color

* style: update popover tokens to pine (#2062)

* style: update input tokens to pine (#2061)

* style: update input tokens

* style: update sage variables to pine

* style: add missing tokens

* style: reorder CSS props

* style: update sage form field message vars

* style: update switch tokens (#2053)

* style: update tokens

* style: hello linter my old friend

* style: hello linter my old friend

* style: update switch tokens

* style: update sage tokens

* style: updated var

---------

Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>

* chore: adds Pine css to imports

* style: update select tokens to pine (#2063)

* style: update tokens

* fix: update icon and color

* style: hello linter my old friend

* fix: hello linter my old friend

* style: updates Badge styles to match Pine Chip (#2064)

* style: updates Badge styles to match Pine Chip

* chore: style linting

* style: update radio tokens (#2054)

* style: update tokens

* style: hello linter my old friend

* style: hello linter my old friend

* style: update radio tokens

* style: update sage token values

* style: add error and checked vars

---------

Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>

* style: updates Tooltip tokens to match Pine (#2067)

---------

Co-authored-by: Ashley Echols <ashley.echols@kajabi.com>
Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants