Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update rtl positioning #2043

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

QuintonJason
Copy link
Contributor

Description

  • resolve empty state positioning in rtl layouts

Screenshots

Before After
Screenshot 2025-01-23 at 7 05 22 PM Screenshot 2025-01-23 at 7 06 16 PM

Testing in sage-lib

Testing in kajabi-products

  1. (LOW) Update Empty State rtl alignment.

Related

@QuintonJason QuintonJason marked this pull request as ready for review January 24, 2025 01:41
@QuintonJason QuintonJason self-assigned this Jan 24, 2025
@QuintonJason QuintonJason requested a review from a team January 24, 2025 01:41
@monicawheeler monicawheeler requested a review from a team January 24, 2025 12:30
@ju-Skinner ju-Skinner requested a review from a team January 24, 2025 12:54
@QuintonJason QuintonJason merged commit 6cb62fa into develop Jan 24, 2025
7 checks passed
ju-Skinner added a commit that referenced this pull request Jan 31, 2025
* style: update Font Family's to match the system installed font name (#2038)

Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>

* style: add border to only catalog item child (#2040)

* style: update rtl positioning (#2043)

* fix: remove button role from react modal (#2044)

* fix: remove rtl logical wrapper (#2041)

* fix: add text dotted underline (#2045)

* fix: add new dotted underline classes

* style: add dotted underline styles

* docs: update docs to include dotted underline

* fix: hello linter my old friend

* style: correct underline dotted styles for better safari support

* style: add selector for icon-only buttons to not rely on icon name (#2046)

* style: add selector for icon-only buttons to not rely on icon name

* style: correct lint error

---------

Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
Co-authored-by: Quinton Jason <quinton.jason@gmail.com>
Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>
@QuintonJason QuintonJason deleted the fix/rtl-update-empty-state-alignment branch March 14, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants