Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple authentication. Fixes #3 #22

Merged
merged 3 commits into from
Sep 16, 2016
Merged

Simple authentication. Fixes #3 #22

merged 3 commits into from
Sep 16, 2016

Conversation

Hiyorimi
Copy link
Contributor

Sorry for not being around for long, now simple authentication

@Hiyorimi Hiyorimi changed the title Simple authentication Simple authentication. Fixes #3 Sep 15, 2016
@Hiyorimi
Copy link
Contributor Author

@Kaixhin please take a look, when you are available.

Kaixhin
Kaixhin requested changes Sep 16, 2016
View reviewed changes
Copy link
Owner

@Kaixhin Kaixhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but you need to add http-auth to package.json as well.

@Hiyorimi
Copy link
Contributor Author

Fixed.

@Kaixhin Kaixhin merged commit 0007397 into Kaixhin:master Sep 16, 2016
@Kaixhin
Copy link
Owner

Kaixhin commented Sep 16, 2016

FYI #3 was mainly about read-only access - that is, being able to view results but not start/delete experiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kaixhin Kaixhin Kaixhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hiyorimi @Kaixhin