Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project management script #663

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Update project management script #663

merged 4 commits into from
Dec 23, 2024

Conversation

stevemessick
Copy link
Contributor

No description provided.

@stevemessick stevemessick changed the title Update script Update project management script Dec 20, 2024
Comment on lines 153 to 155
# rm -rf tox.ini \
# test-requirements.txt \
# test \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe this a comment in bash (correct me if i'm wrong),

do you intend on adding this back? otherwise remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored.

Comment on lines -25 to -26
However, do not try to create a release from within the container. The code formatter
(`yapf3`) changes much more than intended.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to make this "bolder" / stand out a bit.

i think this helpful, but can be over looked with the other text

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the formatter to be consistent within/out container so I removed this warning.

Copy link

@calderjo calderjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks

@stevemessick stevemessick merged commit 73ede3c into main Dec 23, 2024
4 checks passed
@stevemessick stevemessick deleted the update-script branch December 23, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants