Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert competitions to use kagglesdk #625

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Convert competitions to use kagglesdk #625

merged 5 commits into from
Sep 17, 2024

Conversation

stevemessick
Copy link
Contributor

@stevemessick stevemessick commented Aug 23, 2024 •
edited
Loading

The competitions portion of the API now uses kagglesdk.

The HTTP client has ben updated to use prod, if needed.

@stevemessick stevemessick requested review from jplotts and rosbo August 23, 2024 19:46
rosbo
rosbo reviewed Aug 23, 2024
View reviewed changes
kaggle/cli.py Outdated Show resolved Hide resolved
jplotts
jplotts reviewed Aug 26, 2024
View reviewed changes
tests/unit_tests.py Outdated Show resolved Hide resolved
kaggle/api/kaggle_api_extended.py Outdated Show resolved Hide resolved
kaggle/api/kaggle_api_extended.py Outdated Show resolved Hide resolved
kaggle/api/kaggle_api_extended.py Outdated Show resolved Hide resolved
kaggle/api/kaggle_api_extended.py Outdated Show resolved Hide resolved
kaggle/api/kaggle_api_extended.py Outdated Show resolved Hide resolved
kaggle/api/kaggle_api_extended.py Outdated Show resolved Hide resolved
kaggle/api/kaggle_api_extended.py Outdated Show resolved Hide resolved
src/kaggle/api/kaggle_api_extended.py Outdated Show resolved Hide resolved
@stevemessick stevemessick changed the title Convert competitions to use kagglesdk [WIP] Convert competitions to use kagglesdk Aug 27, 2024
jplotts
jplotts reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@jplotts jplotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm going to wait to approve until the prod flag is working, just to ensure that the PR isn't merged too early.

kaggle/api/kaggle_api_extended.py Outdated Show resolved Hide resolved
kaggle/api/kaggle_api_extended.py Outdated Show resolved Hide resolved
kaggle/api/kaggle_api_extended.py Outdated Show resolved Hide resolved
tests/unit_tests.py Outdated Show resolved Hide resolved
@stevemessick stevemessick removed the request for review from rosbo September 13, 2024 23:28
@stevemessick stevemessick changed the title [WIP] Convert competitions to use kagglesdk Convert competitions to use kagglesdk Sep 16, 2024
jplotts
jplotts approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@jplotts jplotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

kaggle/api/kaggle_api_extended.py Show resolved Hide resolved
src/kaggle/api/kaggle_api_extended.py Show resolved Hide resolved
@stevemessick stevemessick merged commit 6a78266 into main Sep 17, 2024
4 checks passed
@stevemessick stevemessick deleted the convert-comps branch September 17, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosbo rosbo rosbo left review comments

@jplotts jplotts jplotts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevemessick @rosbo @jplotts