-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linking issue on electron 1.5+ on Linux #10
Comments
Made it!
With that patch to rebind: diff --git a/rebind/rebind.c b/rebind/rebind.c
index 16252ad..dd16cae 100644
--- a/rebind/rebind.c
+++ b/rebind/rebind.c
@@ -151,7 +151,8 @@ static int changesymbols(Elf64_Sym *symtab, char const *strtab, int count)
name = strtab + sym->st_name;
if (!bsearch(&name, namelist, namecount, sizeof *namelist, qstrcmp))
continue;
- if (chgbind) {
+ sym->st_info = 0;
+ if (0) {
if (ELF64_ST_BIND(sym->st_info) == STB_LOCAL) {
fprintf(stderr, "warning: cannot rebind local symbol \"%s\"\n",
name);
@@ -159,7 +160,7 @@ static int changesymbols(Elf64_Sym *symtab, char const *strtab, int count)
}
sym->st_info = ELF64_ST_INFO(tobind, ELF64_ST_TYPE(sym->st_info));
}
- if (chgvisibility)
+ if (0)
sym->st_other = ELF64_ST_VISIBILITY(tovisibility);
if (verbose)
printf("%s: \"%s\" altered.\n", thefilename, name); So crazy but works. |
Dirty patch just for Kagami/mpv.js#10
Is this workaround still necessary? |
It's fixed in latest versions of Electron (restored explicit dependency on libffmpeg). (Actually it's possible to remove libffmpeg dependency even in latest versions, but it's even more crazy, you need to patch binary for that.) |
electron/libchromiumcontent#268
https://bugs.chromium.org/p/chromium/issues/detail?id=52105
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/M4U8oFpMSSc/aYF187J-S8QJ
The text was updated successfully, but these errors were encountered: