Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action that automatically counts task registrations #918

Merged
merged 7 commits into from
Mar 29, 2021
Merged

Add GitHub action that automatically counts task registrations #918

merged 7 commits into from
Mar 29, 2021

Conversation

gluckzhang
Copy link

@gluckzhang gluckzhang commented Mar 17, 2021

I think somehow I didn't push the python script that publishes registration stats to the repo. So I take this opportunity to make some improvement.

After merging this PR, the devops-course will have a GitHub action that automatically updates the issue body about task registrations. In order to do this, two action secrets need to be specified:

For the administrators of this repo, please visit:
https://github.com/KTH/devops-course/settings/secrets/actions

Then create the following repository secrets:

  • ASSIGNMENT_STAT_CONTRIBUTIONS_PATH: ./contributions (the path to the contributions folder)
  • ASSIGNMENT_STAT_ISSUE_NUMBER: 917 (I have already created this issue)

Now when there is a push event happens in branch 2021, this action will be triggered and the statistics will be updated on the target issue.

@monperrus monperrus changed the title A GitHub action that automatically counts task registerations A GitHub action that automatically counts task registrations Mar 18, 2021
@monperrus
Copy link
Member

Thanks a lot @gluckzhang

@gluckzhang could we also add a PR status stating the result of this action?

@cesarsotovalero could you review and merge it eventually?

@cesarsotovalero
Copy link

cesarsotovalero commented Mar 18, 2021

Thanks, @gluckzhang 👍

@monperrus let's have some students' tasks registered before merging, so we can see the output of this action.

@gluckzhang
Copy link
Author

@gluckzhang could we also add a PR status stating the result of this action?

Hi @monperrus , yes, we can add this action for pull requests. This can be defined in .github/workflows/assignment-statistics.yml:

# Controls when the action will run. 
on:
  # Triggers the workflow on push or pull request events but only for the 2021 branch
  push:
    branches:
    - "2021"
+   pull_request:
+     branches:
+       - "2021"

But I think we will put the result somewhere else because the issue is used to stat all the accepted registrations.

@cesarsotovalero
Copy link

@gluckzhang It's time to see your action "in action" 👍

@cesarsotovalero cesarsotovalero changed the title A GitHub action that automatically counts task registrations Add GitHub action that automatically counts task registrations Mar 29, 2021
@cesarsotovalero cesarsotovalero merged commit 132868e into KTH:2021 Mar 29, 2021
@cesarsotovalero cesarsotovalero added the enhancement New feature or request label Mar 29, 2021
@cesarsotovalero cesarsotovalero self-assigned this Mar 29, 2021
@gluckzhang
Copy link
Author

@gluckzhang It's time to see your action "in action"

Haha, yeah, now the action has been registered. Let's wait for Martin to set up the env values :)

@cesarsotovalero
Copy link

Hi @monperrus Can you add the repo secrets to get this action running?

@gluckzhang
Copy link
Author

Hi @cesarsotovalero , I have set up the rep secrets and the action is working well now :) Thus I deleted the extra comments in the statistic issue to make it neat.

SophieHYe pushed a commit that referenced this pull request Apr 29, 2021
…ary (#1117)

* doc: Course automation proposal

* Add GitHub action that automatically counts task registrations (#918)

* Add tutorial proposal (#1015)

Co-authored-by: LaraRos <rostami.lara@gmail.com>

Co-authored-by: LaraRos <rostami.lara@gmail.com>

* Add essay readme (#1020)

* Executable Tutorial Proposal: Setting up a Jenkins CI/CD pipeline for deploying to Docker Hub (#1028)

* Executable tutorial proposal: integrate TeamCity with Docker (#1025)

Co-authored-by: César Soto Valero <cesarsotovalero@gmail.com>

* Essay: Comparison of Kubernetes and Nomad (#1023)

Co-authored-by: Dina Lerjevik <lerjevik@kth.se>

* Essay proposal: BDD in DevOps (#1032)

* Update README.md (#1039)

* doc: remove confusion about feedback on videos

* Update README.md

* feat: Added workflow file for bibliography summary action #1008

* doc: Final submission update #1008

* doc: Fixed typos

* fix: Changed workflow to use v1 release instead

Co-authored-by: Long Zhang <zhanglong3030@qq.com>
Co-authored-by: Markus Wesslén <markus.wesslen@gmail.com>
Co-authored-by: LaraRos <rostami.lara@gmail.com>
Co-authored-by: Justin Arieltan <agriad1@yahoo.com>
Co-authored-by: Christopher Gustafson <christopher.gustafson@outlook.com>
Co-authored-by: Chen, Zidi <51125655+Chen-Zidi@users.noreply.github.com>
Co-authored-by: César Soto Valero <cesarsotovalero@gmail.com>
Co-authored-by: dmariel <34478937+dmariel@users.noreply.github.com>
Co-authored-by: Dina Lerjevik <lerjevik@kth.se>
Co-authored-by: anorangesky <35503355+anorangesky@users.noreply.github.com>
Co-authored-by: heeenkie <35926672+heeenkie@users.noreply.github.com>
Co-authored-by: Martin Monperrus <martin.monperrus@gnieh.org>
Co-authored-by: Sophie H Ye <he_ye_90s@hotmail.com>
monperrus added a commit that referenced this pull request Sep 15, 2022
…ary (#1117)

* doc: Course automation proposal

* Add GitHub action that automatically counts task registrations (#918)

* Add tutorial proposal (#1015)

Co-authored-by: LaraRos <rostami.lara@gmail.com>

Co-authored-by: LaraRos <rostami.lara@gmail.com>

* Add essay readme (#1020)

* Executable Tutorial Proposal: Setting up a Jenkins CI/CD pipeline for deploying to Docker Hub (#1028)

* Executable tutorial proposal: integrate TeamCity with Docker (#1025)

Co-authored-by: César Soto Valero <cesarsotovalero@gmail.com>

* Essay: Comparison of Kubernetes and Nomad (#1023)

Co-authored-by: Dina Lerjevik <lerjevik@kth.se>

* Essay proposal: BDD in DevOps (#1032)

* Update README.md (#1039)

* doc: remove confusion about feedback on videos

* Update README.md

* feat: Added workflow file for bibliography summary action #1008

* doc: Final submission update #1008

* doc: Fixed typos

* fix: Changed workflow to use v1 release instead

Co-authored-by: Long Zhang <zhanglong3030@qq.com>
Co-authored-by: Markus Wesslén <markus.wesslen@gmail.com>
Co-authored-by: LaraRos <rostami.lara@gmail.com>
Co-authored-by: Justin Arieltan <agriad1@yahoo.com>
Co-authored-by: Christopher Gustafson <christopher.gustafson@outlook.com>
Co-authored-by: Chen, Zidi <51125655+Chen-Zidi@users.noreply.github.com>
Co-authored-by: César Soto Valero <cesarsotovalero@gmail.com>
Co-authored-by: dmariel <34478937+dmariel@users.noreply.github.com>
Co-authored-by: Dina Lerjevik <lerjevik@kth.se>
Co-authored-by: anorangesky <35503355+anorangesky@users.noreply.github.com>
Co-authored-by: heeenkie <35926672+heeenkie@users.noreply.github.com>
Co-authored-by: Martin Monperrus <martin.monperrus@gnieh.org>
Co-authored-by: Sophie H Ye <he_ye_90s@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants