-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Submission] Demo: Docker implementation to React native project #1502
Conversation
There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal. |
Very well done demo! Calm narrative and easy to follow along. The video editing is very good. I think you you did a great job in explaining the process. However, I am a little confused, React Native is primarily used for developing native mobile applications, however, here you are building a web application. I see that this is reflected in the description, but maybe good to emphasize this in the video as well. |
Really Nice Tutorial with some minor things that need to be explained. Nice:
Work on:
Otherwise, I feel as if this video was great. |
Outstanding job with the demo! I've added some comments and suggestions below.
Possible improvements
|
Feedback demo
Things to work on
|
Nice job on the demo, it gives a nice overview of the steps that one needs to take to dockerise front- and back-end, and was easy to follow. You spend quite a lot of time on explaining the basics of Docker, which is nice for beginners, but perhaps a bit unneccessary for the audience of the video (people taking a DevOps course). I'd rather see some more time spent on explaining parts of the configuration you're using (for example, a bit more about the volumes). I'm also a bit confused by React Native, especially since there's |
Great and proffessional demo, I would definitely continue watching if I clicked on it on YouTube!Strengths
Potential improvements
|
This is based on the proposal (#992 )