-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Submission] Demo: Automatically publishing tested Node.js packages on npm with Github Actions #1484
Conversation
There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal. |
Ping @cesarsotovalero as you accepted my proposal 😀 |
I have always wondered how you published npm packages! And you even automated the process, great video! The content and the structure is great. I have a few suggestions that would make the video "flow" more.
Otherwise, this was a great video! Have a good one. |
Great Work.
|
Demo Feedback Overall really useful, interesting, clear and good demo! Positive
Negative
|
FeedbackReally interesting demo. I like the topic. The voice over and subtitles were good. Sometimes the text is probably a bit too small. I mainly thinking of when you are showing GitHub and the terminal window. You could perhaps use the zoom functionality in the browser to have less whitespace and either use a larger font in your terminal or simply use the integrated terminal in VS Code (you can even default to WSL and open with a shortcut). I liked that the voice over sounded very calm and that you didn't rush through anything. That made it easy to follow. 👍 |
FeedbackA very interesting and informative demo! I've listed the strengths and a few suggestions for improvement below. Otherwise, good job 👍 Strengths
Suggestions for improvement
|
Great demo! The video content was easy to understand, the speed was good, the voice over was clear and the subtitles correct. In addition, the editing had high quality, and the background music and the included slides were small details that increased the overall feel. I don't really have any problems to pinpoint. One thing that could increase the watching experience, would be to highlight relevant parts on the screen when there is something specific that we should look at. For instance at time stamp 2:37, you mention that we can see that the publish workflow is triggered and you show the GitHub Actions page. If you are unfamiliar with GitHub Actions, it can be hard to know where on the screen you should look to see that the workflow is indeed running. In that case, highlighting the specific workflow in the list (e.g. by drawing an arrow, drawing a square, or blurring everything else) would make it easier to follow along. |
Submission for #1152