Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final submission #1432

Closed
wants to merge 1 commit into from
Closed

Final submission #1432

wants to merge 1 commit into from

Conversation

Wkkkkk
Copy link

@Wkkkkk Wkkkkk commented Apr 30, 2021

This pr includes the final version of the essay proposal.
The initial proposal and a conflicted submission proposal can be found in the link.

Feedback from Ayub Atif and Isac Arvidsson has been submitted.

@Wkkkkk
Copy link
Author

Wkkkkk commented Apr 30, 2021

Sorry for this confusion.

@khaes-kth
Copy link

Hi @Wkkkkk

Can you please explain the difference between this PR and #1379. I remember we discussed something in the lab session, but I don't exactly remember what was the problem.

@khaes-kth khaes-kth self-assigned this May 3, 2021
@khaes-kth khaes-kth added final_submission The final submission of a task essay One of the task categories listed in README.md labels May 3, 2021
@Wkkkkk
Copy link
Author

Wkkkkk commented May 3, 2021

Hi @khaes-kth

Sorry for this mess. PR #1379 includes the initial essay and some peers have given their feedback on that version. When I was creating this RP, my feedback on another essay was also committed by mistake, which results in a conflict. After I read the feedback and polished my essay, I made this new PR to submit the final version of the essay.

@Wkkkkk
Copy link
Author

Wkkkkk commented May 3, 2021

The merged essay at this moment is actually the initial one. I really appreciate your help if the final version attached to this PR could be merged.

@khaes-kth
Copy link

Hi @Wkkkkk

Let's do it the simple way. Save your latest changes in your computer. Unfork the repo, fork it again, clone the new forked version, copy the latest changes to the repo, push it and create a new PR. When you have done these, ping me in the new PR.

If you can fix this PR to only change the essay folder and resolve the conflict, it is great. If not, do it the simple way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
essay One of the task categories listed in README.md final_submission The final submission of a task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants