Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission: feedback on essay #1399

Merged
merged 20 commits into from
May 4, 2021
Merged

Conversation

isacarvid
Copy link

@isacarvid isacarvid commented Apr 27, 2021

Members: @isacarvid (isacarv@kth.se)
Feedback proposal can be found in #1128
Feedback comment here

task Yes No Remarkable
The feedback includes both strengths and weaknesses about the task Yes - -
The feedback is provided 4 business days before the task deadline Yes - -
All points are clearly actionable Yes - -
The feedback is substantiated Yes (at least 500 words) - -
The feedback contains pointers to additional material Yes - -
The students act upon the feedback they receive  yes(I hope so) - -  

@khaes-kth khaes-kth self-assigned this May 3, 2021
@khaes-kth
Copy link

hi @isacarvid

Your feedback submission should only change the contributions/feedback folder. This PR is also changing the contributions/essay directory. Please fix it ASAP.

@github-actions github-actions bot added essay One of the task categories listed in README.md feedback final_submission The final submission of a task labels May 4, 2021
@github-actions
Copy link

github-actions bot commented May 4, 2021

There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal.

@isacarvid
Copy link
Author

Hi @khaes-kth!
I fixed the PR so that it only changes the feedback folder. Thanks for the heads up!

@khaes-kth
Copy link

I fixed the PR so that it only changes the feedback folder

Great.

Please add a link to your feedback comment to your README.

@github-actions
Copy link

github-actions bot commented May 4, 2021

There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal.

@github-actions
Copy link

github-actions bot commented May 4, 2021

There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal.

@github-actions
Copy link

github-actions bot commented May 4, 2021

There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal.

@isacarvid
Copy link
Author

isacarvid commented May 4, 2021

Please add a link to your feedback comment to your README.

thanks, @khaes-kth, It's done!

@khaes-kth khaes-kth merged commit 850ab7e into KTH:2021 May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
essay One of the task categories listed in README.md feedback final_submission The final submission of a task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants