-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback submission on essay draft #1023 #1392
Conversation
Hi @IfyUrama Your submission should only change the |
There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal. |
The ID:s constituting the folder name matched with the email addresses in the README file. |
The ID:s constituting the folder name matched with the email addresses in the README file. |
The ID:s constituting the folder name matched with the email addresses in the README file. |
@khaes-kth The submission is now on contributions/feedback/urama/README.md |
There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal. |
There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal. |
Feedback submission update.
There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal. |
I think your PR is removing the presentation README. Check your repo here. |
Hi @khaes-th,
I don't think so. Our real presentation folder was made by my colleague. I tried to make the pull request, but had some issues, so my colleague did it. The presentation README you saw I deleted it the unused one I made.
Hope it's ok now?
Sent from Yahoo Mail on Android
On Tue, 4 May 2021 at 10:54, Khashayar ***@***.***> wrote:
@khaes-kth The submission is now on contributions/feedback/urama/README.md
I think your PR is removing the presentation README. Check your repo here.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Modified changes made.
There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal. |
Hi @khaes-kth, Should I close this pull request and make a new one to resubmit my feedback? |
@IfyUrama If you think that would solve the issue with your PR, you can to it. |
I just noticed you have created another PR with similar content (#1482). So I'm closing this one. |
No description provided.