Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback submission on essay draft #1023 #1392

Closed
wants to merge 9 commits into from
Closed

Conversation

IfyUrama
Copy link

@IfyUrama IfyUrama commented Apr 27, 2021

No description provided.

@khaes-kth
Copy link

Hi @IfyUrama

Your submission should only change the contributions/feedback folder. This PR is also changing the contributions/presentation folder. Please fix it soon.

@github-actions github-actions bot added essay One of the task categories listed in README.md feedback final_submission The final submission of a task labels May 3, 2021
@IfyUrama IfyUrama closed this May 3, 2021
@IfyUrama IfyUrama reopened this May 3, 2021
@github-actions
Copy link

github-actions bot commented May 3, 2021

There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal.

@github-actions
Copy link

github-actions bot commented May 3, 2021

The ID:s constituting the folder name matched with the email addresses in the README file.
The group consisting of urama, appears to have worked together 1 times.
Maximum group size allowed: 3.
Maximum number of collaborations allowed: 2.
The group composition is allowed.

@IfyUrama IfyUrama closed this May 3, 2021
@IfyUrama IfyUrama reopened this May 3, 2021
@github-actions
Copy link

github-actions bot commented May 3, 2021

The ID:s constituting the folder name matched with the email addresses in the README file.
The group consisting of urama, appears to have worked together 1 times.
Maximum group size allowed: 3.
Maximum number of collaborations allowed: 2.
The group composition is allowed.

@IfyUrama IfyUrama closed this May 3, 2021
@IfyUrama IfyUrama reopened this May 3, 2021
@github-actions
Copy link

github-actions bot commented May 3, 2021

The ID:s constituting the folder name matched with the email addresses in the README file.
The group consisting of urama, appears to have worked together 1 times.
Maximum group size allowed: 3.
Maximum number of collaborations allowed: 2.
The group composition is allowed.

@IfyUrama
Copy link
Author

IfyUrama commented May 3, 2021

@khaes-kth The submission is now on contributions/feedback/urama/README.md

@github-actions
Copy link

github-actions bot commented May 3, 2021

There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal.

@github-actions
Copy link

github-actions bot commented May 3, 2021

There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal.

Feedback submission update.
@github-actions
Copy link

github-actions bot commented May 3, 2021

There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal.

@khaes-kth
Copy link

@khaes-kth The submission is now on contributions/feedback/urama/README.md

I think your PR is removing the presentation README. Check your repo here.

@IfyUrama
Copy link
Author

IfyUrama commented May 4, 2021 via email

@khaes-kth
Copy link

Here you can see the files your PR is changing. It is removing the already merged README of your presentation. Here is the the merged directory for your presentation. And here is your directory.

You may need to rebase your branch to fix this issue.

Modified changes made.
@github-actions
Copy link

github-actions bot commented May 6, 2021

There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal.

@IfyUrama
Copy link
Author

IfyUrama commented May 6, 2021

Hi @khaes-kth,

Should I close this pull request and make a new one to resubmit my feedback?

@khaes-kth
Copy link

@IfyUrama If you think that would solve the issue with your PR, you can to it.

@khaes-kth
Copy link

I just noticed you have created another PR with similar content (#1482). So I'm closing this one.

@khaes-kth khaes-kth closed this May 6, 2021
@IfyUrama IfyUrama mentioned this pull request May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
essay One of the task categories listed in README.md feedback final_submission The final submission of a task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants